From 75503b0e639992372e49fbf20ac94bc70205f6d6 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Sat, 31 Jan 2026 20:28:54 +0000 Subject: [PATCH 1/2] python3Packages.fastmri: use finalAttrs --- pkgs/development/python-modules/fastmri/default.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/development/python-modules/fastmri/default.nix b/pkgs/development/python-modules/fastmri/default.nix index 5b5be75d08bd..9b058f093083 100644 --- a/pkgs/development/python-modules/fastmri/default.nix +++ b/pkgs/development/python-modules/fastmri/default.nix @@ -23,7 +23,7 @@ pytestCheckHook, }: -buildPythonPackage rec { +buildPythonPackage (finalAttrs: { pname = "fastmri"; version = "0.3.0"; pyproject = true; @@ -31,7 +31,7 @@ buildPythonPackage rec { src = fetchFromGitHub { owner = "facebookresearch"; repo = "fastMRI"; - tag = "v${version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-0IJV8OhY5kPWQwUYPKfmdI67TyYzDAPlwohdc0jWcV4="; }; @@ -76,8 +76,8 @@ buildPythonPackage rec { meta = { description = "Pytorch-based MRI reconstruction tooling"; homepage = "https://github.com/facebookresearch/fastMRI"; - changelog = "https://github.com/facebookresearch/fastMRI/releases/tag/v${version}"; + changelog = "https://github.com/facebookresearch/fastMRI/releases/tag/${finalAttrs.src.tag}"; license = lib.licenses.mit; maintainers = with lib.maintainers; [ osbm ]; }; -} +}) From 205ea5d2204ea659bb30fe48a25b657803abf834 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Sat, 31 Jan 2026 20:33:47 +0000 Subject: [PATCH 2/2] python3Packages.fastmri: skip failing tests on python>=3.14 Tracking: https://github.com/NixOS/nixpkgs/issues/475732 --- pkgs/development/python-modules/fastmri/default.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/development/python-modules/fastmri/default.nix b/pkgs/development/python-modules/fastmri/default.nix index 9b058f093083..1a2e61ab620f 100644 --- a/pkgs/development/python-modules/fastmri/default.nix +++ b/pkgs/development/python-modules/fastmri/default.nix @@ -2,6 +2,7 @@ lib, buildPythonPackage, fetchFromGitHub, + pythonAtLeast, # build system setuptools, @@ -66,6 +67,12 @@ buildPythonPackage (finalAttrs: { nativeCheckInputs = [ pytestCheckHook ]; + disabledTests = lib.optionals (pythonAtLeast "3.14") [ + # AttributeError: '...' object has no attribute '__annotations__'. + "test_unet_scripting" + "test_varnet_scripting" + ]; + disabledTestPaths = [ # much older version of pytorch-lightning is used "tests/test_modules.py"