From acba6877216936862d3f8b5a87f16cfe2dfe3918 Mon Sep 17 00:00:00 2001 From: nikstur Date: Wed, 29 May 2024 16:13:30 +0200 Subject: [PATCH] nixos/version: remove strict type constraints from image options This constraints aren't super useful because they arent really enforced by the software, so it's hard to get them right and we've gotten them wrong multiple times in the past. It's better to remove them altogether in the spirit of RFC 42. --- nixos/modules/misc/version.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nixos/modules/misc/version.nix b/nixos/modules/misc/version.nix index 29e9498018ec..db917f73a064 100644 --- a/nixos/modules/misc/version.nix +++ b/nixos/modules/misc/version.nix @@ -121,7 +121,7 @@ in image = { id = lib.mkOption { - type = types.nullOr (types.strMatching "^[a-z0-9._-]+$"); + type = types.nullOr types.str; default = null; description = '' Image identifier. @@ -135,7 +135,7 @@ in }; version = lib.mkOption { - type = types.nullOr (types.strMatching "^[a-z0-9._-~^]+$"); + type = types.nullOr types.str; default = null; description = '' Image version.