From ac86e53eda03d201c61eef7b388568ee6dfeb8f9 Mon Sep 17 00:00:00 2001 From: Tobias Mayer Date: Sat, 27 Jul 2024 12:05:59 +0200 Subject: [PATCH] re2: fix static, always build tests --- pkgs/development/libraries/re2/default.nix | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/pkgs/development/libraries/re2/default.nix b/pkgs/development/libraries/re2/default.nix index 09d2f7539f15..9c56de38514b 100644 --- a/pkgs/development/libraries/re2/default.nix +++ b/pkgs/development/libraries/re2/default.nix @@ -36,20 +36,19 @@ stdenv.mkDerivation (finalAttrs: { ninja ]; - buildInputs = lib.optionals finalAttrs.doCheck [ + buildInputs = [ gbenchmark gtest ]; - propagatedBuildInputs = [ - abseil-cpp - icu - ]; + propagatedBuildInputs = [ abseil-cpp ] ++ lib.optionals (!stdenv.hostPlatform.isStatic) [ icu ]; - cmakeFlags = [ - (lib.cmakeBool "RE2_BUILD_TESTING" finalAttrs.doCheck) - (lib.cmakeBool "RE2_USE_ICU" true) - ] ++ lib.optional (!stdenv.hostPlatform.isStatic) (lib.cmakeBool "BUILD_SHARED_LIBS" true); + cmakeFlags = + [ (lib.cmakeBool "RE2_BUILD_TESTING" true) ] + ++ lib.optionals (!stdenv.hostPlatform.isStatic) [ + (lib.cmakeBool "RE2_USE_ICU" true) + (lib.cmakeBool "BUILD_SHARED_LIBS" true) + ]; doCheck = true;