From 46be72d31539780a988f60b3a5f46bc3726d9bad Mon Sep 17 00:00:00 2001 From: Johannes Kirschbauer Date: Fri, 30 May 2025 22:39:51 +0200 Subject: [PATCH 1/2] nixos/unitOption: remove unnecessary definition filtering --- nixos/lib/systemd-unit-options.nix | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/nixos/lib/systemd-unit-options.nix b/nixos/lib/systemd-unit-options.nix index 0ddae4e20198..eff78fef265d 100644 --- a/nixos/lib/systemd-unit-options.nix +++ b/nixos/lib/systemd-unit-options.nix @@ -15,7 +15,6 @@ let inherit (lib) any concatMap - filterOverrides isList literalExpression mergeEqualOption @@ -56,13 +55,10 @@ rec { name = "systemd option"; merge = loc: defs: - let - defs' = filterOverrides defs; - in - if any (def: isList def.value) defs' then - concatMap (def: toList def.value) defs' + if any (def: isList def.value) defs then + concatMap (def: toList def.value) defs else - mergeEqualOption loc defs'; + mergeEqualOption loc defs; }; sharedOptions = { From 6d8eca96ba0a8d55bbc4e4e1f21b7e1fa0d52e61 Mon Sep 17 00:00:00 2001 From: Johannes Kirschbauer Date: Fri, 30 May 2025 22:45:46 +0200 Subject: [PATCH 2/2] sysctl: remove unnecessary definition filtering --- nixos/modules/config/sysctl.nix | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/nixos/modules/config/sysctl.nix b/nixos/modules/config/sysctl.nix index 45f25180e07b..6489b406b2c7 100644 --- a/nixos/modules/config/sysctl.nix +++ b/nixos/modules/config/sysctl.nix @@ -9,7 +9,7 @@ let checkType = x: lib.isBool x || lib.isString x || lib.isInt x || x == null; in checkType val || (val._type or "" == "override" && checkType val.content); - merge = loc: defs: lib.mergeOneOption loc (lib.filterOverrides defs); + merge = loc: defs: lib.mergeOneOption loc defs; }; in @@ -22,9 +22,7 @@ in type = let highestValueType = lib.types.ints.unsigned // { - merge = - loc: defs: - lib.foldl (a: b: if b.value == null then null else lib.max a b.value) 0 (lib.filterOverrides defs); + merge = loc: defs: lib.foldl (a: b: if b.value == null then null else lib.max a b.value) 0 defs; }; in lib.types.submodule {