From aa3ba4cb2314c81f4de495a2d99fe60705311a5a Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 24 Feb 2025 21:54:59 +0100 Subject: [PATCH] electron-bin: don't wrap inside libexec --- .../tools/electron/binary/generic.nix | 24 ++++++++----------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/pkgs/development/tools/electron/binary/generic.nix b/pkgs/development/tools/electron/binary/generic.nix index 792ad818a20c..42bb8ed3799f 100644 --- a/pkgs/development/tools/electron/binary/generic.nix +++ b/pkgs/development/tools/electron/binary/generic.nix @@ -157,25 +157,21 @@ let chmod u-x $out/libexec/electron/*.so* ''; - # We use null here to not cause unnecessary rebuilds. - dontWrapGApps = if needsAarch64PageSizeFix then true else null; - preFixup = - if needsAarch64PageSizeFix then - '' - wrapProgram "$out/libexec/electron/chrome_crashpad_handler" "''${gappsWrapperArgs[@]}" - wrapProgram "$out/libexec/electron/chrome-sandbox" "''${gappsWrapperArgs[@]}" - wrapProgram "$out/libexec/electron/electron" "''${gappsWrapperArgs[@]}" \ - --add-flags "--js-flags=--no-decommit-pooled-pages" - '' - else - null; + # We don't want to wrap the contents of $out/libexec automatically + dontWrapGApps = true; + + preFixup = '' + makeWrapper "$out/libexec/electron/electron" $out/bin/electron \ + "''${gappsWrapperArgs[@]}" \ + ${lib.optionalString needsAarch64PageSizeFix "--add-flags '--js-flags=--no-decommit-pooled-pages'"} + ''; postFixup = '' patchelf \ --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \ --set-rpath "${electronLibPath}:$out/libexec/electron" \ - $out/libexec/electron/.electron-wrapped \ - $out/libexec/electron/.chrome_crashpad_handler-wrapped + $out/libexec/electron/electron \ + $out/libexec/electron/chrome_crashpad_handler # patch libANGLE patchelf \