From aeda960a06dca1e7139c590ff352da13d634f2aa Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Wed, 5 Nov 2025 00:12:36 +0530 Subject: [PATCH 1/3] asciinema-agg: add phanirithvij as maintainer Signed-off-by: phanirithvij --- pkgs/by-name/as/asciinema-agg/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/as/asciinema-agg/package.nix b/pkgs/by-name/as/asciinema-agg/package.nix index 70a9fa8cb661..9ef7f7513b36 100644 --- a/pkgs/by-name/as/asciinema-agg/package.nix +++ b/pkgs/by-name/as/asciinema-agg/package.nix @@ -24,7 +24,7 @@ rustPlatform.buildRustPackage rec { homepage = "https://github.com/asciinema/agg"; changelog = "https://github.com/asciinema/agg/releases/tag/${src.rev}"; license = licenses.asl20; - maintainers = [ ]; + maintainers = with lib.maintainers; [ phanirithvij ]; mainProgram = "agg"; }; } From d412e7fa62f8945c98b59518f3b1cbf84c801e36 Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Wed, 5 Nov 2025 00:12:56 +0530 Subject: [PATCH 2/3] asciinema-agg: refactor to finalAttrs Signed-off-by: phanirithvij --- pkgs/by-name/as/asciinema-agg/package.nix | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkgs/by-name/as/asciinema-agg/package.nix b/pkgs/by-name/as/asciinema-agg/package.nix index 9ef7f7513b36..12d80c24ed45 100644 --- a/pkgs/by-name/as/asciinema-agg/package.nix +++ b/pkgs/by-name/as/asciinema-agg/package.nix @@ -4,14 +4,14 @@ fetchFromGitHub, }: -rustPlatform.buildRustPackage rec { +rustPlatform.buildRustPackage (finalAttrs: { pname = "agg"; version = "1.7.0"; src = fetchFromGitHub { owner = "asciinema"; repo = "agg"; - rev = "v${version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-6UenPE6mmmvliaIuGdQj/FrlmoJvmBJgfo0hW+uRaxM="; }; @@ -19,12 +19,12 @@ rustPlatform.buildRustPackage rec { cargoHash = "sha256-VpbjvrMhzS1zrcMNWBjTLda6o3ea2cwpnEDUouwyp8w="; - meta = with lib; { + meta = { description = "Command-line tool for generating animated GIF files from asciicast v2 files produced by asciinema terminal recorder"; homepage = "https://github.com/asciinema/agg"; - changelog = "https://github.com/asciinema/agg/releases/tag/${src.rev}"; - license = licenses.asl20; + changelog = "https://github.com/asciinema/agg/releases/tag/${finalAttrs.src.tag}"; + license = lib.licenses.asl20; maintainers = with lib.maintainers; [ phanirithvij ]; mainProgram = "agg"; }; -} +}) From 0e83a63fe1857cba450587c4af5b5148aebd2907 Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Wed, 5 Nov 2025 00:12:59 +0530 Subject: [PATCH 3/3] asciinema-agg: add versionCheckHook Signed-off-by: phanirithvij --- pkgs/by-name/as/asciinema-agg/package.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/by-name/as/asciinema-agg/package.nix b/pkgs/by-name/as/asciinema-agg/package.nix index 12d80c24ed45..722988ea6fd6 100644 --- a/pkgs/by-name/as/asciinema-agg/package.nix +++ b/pkgs/by-name/as/asciinema-agg/package.nix @@ -2,6 +2,7 @@ lib, rustPlatform, fetchFromGitHub, + versionCheckHook, }: rustPlatform.buildRustPackage (finalAttrs: { @@ -19,6 +20,10 @@ rustPlatform.buildRustPackage (finalAttrs: { cargoHash = "sha256-VpbjvrMhzS1zrcMNWBjTLda6o3ea2cwpnEDUouwyp8w="; + doInstallCheck = true; + nativeInstallCheckInputs = [ versionCheckHook ]; + versionCheckProgramArg = "--version"; + meta = { description = "Command-line tool for generating animated GIF files from asciicast v2 files produced by asciinema terminal recorder"; homepage = "https://github.com/asciinema/agg";