gador/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci/github-script/labels: prevent closing purposely-empty PRs

Browse Source 
Some PRs are empty on purpose, for example the yearly notification about
the election for voters. We should not close these because the merge
commit is empty - only if there was a change intended, but the merge
commit *becomes* empty, we should act.
This commit is contained in:
Wolfgang Walther
2025-10-19 11:27:00 +02:00
parent 5060c0ea6a
commit a705a34a22
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ci/github-script/labels.js
View File

@@ -26,7 +26,10 @@ module.exports = async ({ github, context, core, dry }) => {
// be detected, no maintainers pinged. // be detected, no maintainers pinged.
// We can just check the temporary merge commit, and if it's empty the PR can safely be // We can just check the temporary merge commit, and if it's empty the PR can safely be
// closed - there are no further changes. // closed - there are no further changes.
if (pull_request.merge_commit_sha) { // We only do this for PRs, which are non-empty to start with. This avoids closing PRs
// which have been created with an empty commit for notification purposes, for example
// the yearly election notification for voters.
if (pull_request.merge_commit_sha && pull_request.changed_files > 0) {
const commit = ( const commit = (
await github.rest.repos.getCommit({ await github.rest.repos.getCommit({
...context.repo, ...context.repo,