From a546a8e027ffb1b4edbcbcfd92ec7f9c2ab12e18 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 27 Aug 2025 23:29:13 +0200 Subject: [PATCH] nodejs_24: 24.6.0 -> 24.7.0 --- pkgs/development/web/nodejs/v24.nix | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/pkgs/development/web/nodejs/v24.nix b/pkgs/development/web/nodejs/v24.nix index 39db9d1328bf..3e4a128d368b 100644 --- a/pkgs/development/web/nodejs/v24.nix +++ b/pkgs/development/web/nodejs/v24.nix @@ -17,8 +17,8 @@ let in buildNodejs { inherit enableNpm; - version = "24.6.0"; - sha256 = "8ad5c387b5d55d8f3b783b0f1b21bae03a3b3b10ac89a25d266cffa7b795e842"; + version = "24.7.0"; + sha256 = "cf74a77753b629ffebd2e38fb153a21001b2b7a3c365c0ec7332b120b98c7251"; patches = ( if (stdenv.hostPlatform.emulatorAvailable buildPackages) then @@ -47,10 +47,18 @@ buildNodejs { ++ [ ./configure-armv6-vfpv2.patch ./disable-darwin-v8-system-instrumentation-node19.patch - ./bypass-darwin-xcrun-node16.patch ./node-npm-build-npm-package-logic.patch ./use-correct-env-in-tests.patch ./bin-sh-node-run-v22.patch + + # TODO: newer GYP versions have been patched to be more compatible with Nix sandbox. We need + # to adapt our patch to this newer version, see https://github.com/NixOS/nixpkgs/pull/434742. + (fetchpatch2 { + url = "https://github.com/nodejs/node/commit/886e4b3b534a9f3ad2facbc99097419e06615900.patch?full_index=1"; + hash = "sha256-HFTabl92NPkBwXD0mUGDN+Gzabyi+Ph0kL0FEHHknbk="; + revert = true; + }) + ./bypass-darwin-xcrun-node16.patch ] ++ lib.optionals (!stdenv.buildPlatform.isDarwin) [ # test-icu-env is failing without the reverts