From a1a493d0b7e56d31e2e15dd940ac8d0ca46b344e Mon Sep 17 00:00:00 2001
From: Tomodachi94 <tomodachi94@protonmail.com>
Date: Mon, 9 Dec 2024 17:31:27 +0000
Subject: [PATCH] python3Packages.jaeger-client: drop

Unmaintained:
https://github.com/jaegertracing/jaeger-client-python?tab=readme-ov-file#-this-library-is-deprecated

Replaced by OpenTelemetry:
https://opentelemetry.io/
---
 .../manual/release-notes/rl-2505.section.md   |  2 +
 .../python-modules/jaeger-client/default.nix  | 42 -------------------
 pkgs/top-level/python-aliases.nix             |  1 +
 pkgs/top-level/python-packages.nix            |  2 -
 4 files changed, 3 insertions(+), 44 deletions(-)
 delete mode 100644 pkgs/development/python-modules/jaeger-client/default.nix

diff --git a/nixos/doc/manual/release-notes/rl-2505.section.md b/nixos/doc/manual/release-notes/rl-2505.section.md
index f173d0d93b1d..e78a8af227f4 100644
--- a/nixos/doc/manual/release-notes/rl-2505.section.md
+++ b/nixos/doc/manual/release-notes/rl-2505.section.md
@@ -64,6 +64,8 @@
 
 - The behavior of the `networking.nat.externalIP` and `networking.nat.externalIPv6` options has been changed. `networking.nat.forwardPorts` now only forwards packets destined for the specified IP addresses.
 
+- `python3Packages.jaeger-client` was removed because it was deprecated upstream. [OpenTelemetry](https://opentelemetry.io) is the recommended replacement.
+
 - `nodePackages.meshcommander` has been removed, as the package was deprecated by Intel.
 
 - `kanata` was updated to v1.7.0, which introduces several breaking changes.
diff --git a/pkgs/development/python-modules/jaeger-client/default.nix b/pkgs/development/python-modules/jaeger-client/default.nix
deleted file mode 100644
index c976fca5d634..000000000000
--- a/pkgs/development/python-modules/jaeger-client/default.nix
+++ /dev/null
@@ -1,42 +0,0 @@
-{
-  buildPythonPackage,
-  fetchPypi,
-  lib,
-  opentracing,
-  threadloop,
-  thrift,
-  tornado,
-}:
-
-buildPythonPackage rec {
-  pname = "jaeger-client";
-  version = "4.8.0";
-  format = "setuptools";
-
-  src = fetchPypi {
-    inherit pname version;
-    sha256 = "3157836edab8e2c209bd2d6ae61113db36f7ee399e66b1dcbb715d87ab49bfe0";
-  };
-
-  propagatedBuildInputs = [
-    threadloop
-    thrift
-    tornado
-    opentracing
-  ];
-
-  # FIXME: Missing dependencies: tchannel, opentracing_instrumentation
-  # opentracing_instrumentation: Requires "tornado" lower than 6. Current is 6.1.
-  # https://github.com/uber-common/opentracing-python-instrumentation/pull/115
-  doCheck = false;
-
-  pythonImportsCheck = [ "jaeger_client" ];
-
-  meta = with lib; {
-    description = "Jaeger bindings for Python OpenTracing API";
-    downloadPage = "https://pypi.org/project/jaeger-client/";
-    homepage = "https://github.com/jaegertracing/jaeger-client-python";
-    license = licenses.asl20;
-    maintainers = [ ];
-  };
-}
diff --git a/pkgs/top-level/python-aliases.nix b/pkgs/top-level/python-aliases.nix
index 7c18c3d69dd2..cd5fb65d14ce 100644
--- a/pkgs/top-level/python-aliases.nix
+++ b/pkgs/top-level/python-aliases.nix
@@ -284,6 +284,7 @@ mapAliases ({
   ipython_genutils = ipython-genutils; # added 2023-10-12
   influxgraph = throw "influxgraph has been removed because it is no longer maintained"; # added 2022-07-10
   itanium_demangler = itanium-demangler; # added 2022-10-17
+  jaeger-client = throw "jaeger-client was removed because it is deprecated upstream. OpenTelemetry is recommended instead."; # Added 2024-12-09
   jaraco_classes = jaraco-classes; # added 2023-07-14
   jaraco_collections = jaraco-collections; # added 2023-07-14
   jaraco_functools = jaraco-functools; # added 2023-07-14
diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index fecbbeecaa84..41b6a09ecfbe 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -6491,8 +6491,6 @@ self: super: with self; {
 
   jaconv = callPackage ../development/python-modules/jaconv { };
 
-  jaeger-client = callPackage ../development/python-modules/jaeger-client { };
-
   jalali-core = callPackage ../development/python-modules/jalali-core { };
 
   jamo = callPackage ../development/python-modules/jamo { };