From a137aa33cbcadb195bed56823d6a29a316756ff8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Forsman?= Date: Sun, 5 Jan 2025 21:38:26 +0100 Subject: [PATCH] homepage-dashboard: use subshell instead of pushd/popd I find less state easier to reason about. --- pkgs/servers/homepage-dashboard/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/servers/homepage-dashboard/default.nix b/pkgs/servers/homepage-dashboard/default.nix index 1b7ce62ddb9c..f586ede472df 100644 --- a/pkgs/servers/homepage-dashboard/default.nix +++ b/pkgs/servers/homepage-dashboard/default.nix @@ -78,9 +78,7 @@ buildNpmPackage rec { # This patch ensures that the cache implementation respects the env # variable `HOMEPAGE_CACHE_DIR`, which is set by default in the # wrapper below. - pushd $out - patch -p1 <${./prerender_cache_path.patch} - popd + (cd "$out" && patch -p1 <${./prerender_cache_path.patch}) makeWrapper $out/share/homepage/server.js $out/bin/homepage \ --set-default PORT 3000 \