From 9febe2f8fcf302b98643ea035824ba82b1b28d29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Tue, 4 Aug 2020 21:49:34 +0200 Subject: [PATCH] mesa: fold override of patchelf inside whole build Overriding it just for .drivers had the advantage of limiting rebuilds, but it seems less clean and apparently it can interact a bit surprisingly with some other overrides. /cc #94444. Also this will get removed once patchelf gets updated. --- pkgs/development/libraries/mesa/default.nix | 11 +++++++++++ pkgs/top-level/all-packages.nix | 18 +----------------- 2 files changed, 12 insertions(+), 17 deletions(-) diff --git a/pkgs/development/libraries/mesa/default.nix b/pkgs/development/libraries/mesa/default.nix index 10540e5e3039..9a2eda5e7104 100644 --- a/pkgs/development/libraries/mesa/default.nix +++ b/pkgs/development/libraries/mesa/default.nix @@ -4,6 +4,7 @@ , llvmPackages, libffi, libomxil-bellagio, libva-minimal , libelf, libvdpau, python3Packages , libglvnd +, patchelf, autoreconfHook, fetchFromGitHub , enableRadv ? true , galliumDrivers ? ["auto"] , driDrivers ? ["auto"] @@ -126,6 +127,16 @@ stdenv.mkDerivation { depsBuildBuild = [ pkgconfig ]; nativeBuildInputs = [ + (patchelf.overrideAttrs (pa: { + src = fetchFromGitHub { + owner = "NixOS"; + repo = "patchelf"; + rev = "61bc10176"; # current master; what matters is merge of #225 + sha256 = "0cy77mn77w3mn64ggp20f4ygnbxfjmddhjjhfwkva53lsirg6w93"; + }; + nativeBuildInputs = pa.nativeBuildInputs or [] ++ [ autoreconfHook ]; + })) + ] ++ [ pkgconfig meson ninja intltool bison flex file python3Packages.python python3Packages.Mako diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 4fdd8ca992ad..9f616a4a51e9 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -14035,23 +14035,7 @@ in llvmPackages = llvmPackages_9; inherit (darwin.apple_sdk.frameworks) OpenGL; inherit (darwin.apple_sdk.libs) Xplugin; - } - # Temporary fix for .drivers that avoids causing lots of rebuilds; see #91145 - // { drivers = (mesa.overrideAttrs (a: { - nativeBuildInputs = [ - (patchelf.overrideAttrs (pa: { - src = fetchFromGitHub { - owner = "NixOS"; - repo = "patchelf"; - rev = "61bc10176"; # current master; what matters is merge of #225 - sha256 = "0cy77mn77w3mn64ggp20f4ygnbxfjmddhjjhfwkva53lsirg6w93"; - }; - nativeBuildInputs = pa.nativeBuildInputs or [] ++ [ autoreconfHook ]; - })) - ] ++ a.nativeBuildInputs or []; - })).drivers; - } - ; + }; mesa_glu = callPackage ../development/libraries/mesa-glu { inherit (darwin.apple_sdk.frameworks) ApplicationServices;