From 9eca444abb5713510b8394b9d44d23c85790e40f Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Thu, 16 Apr 2026 07:53:58 +0000
Subject: [PATCH] python3Packages.sentence-transformers: 5.3.0 -> 5.4.1

Diff: https://github.com/huggingface/sentence-transformers/compare/v5.3.0...v5.4.1

Changelog: https://github.com/huggingface/sentence-transformers/releases/tag/v5.4.1
---
 .../sentence-transformers/default.nix         | 43 +++++++++----------
 1 file changed, 21 insertions(+), 22 deletions(-)

diff --git a/pkgs/development/python-modules/sentence-transformers/default.nix b/pkgs/development/python-modules/sentence-transformers/default.nix
index 7983ee7d711f..743adf0efdcb 100644
--- a/pkgs/development/python-modules/sentence-transformers/default.nix
+++ b/pkgs/development/python-modules/sentence-transformers/default.nix
@@ -34,14 +34,14 @@
 
 buildPythonPackage (finalAttrs: {
   pname = "sentence-transformers";
-  version = "5.3.0";
+  version = "5.4.1";
   pyproject = true;
 
   src = fetchFromGitHub {
     owner = "huggingface";
     repo = "sentence-transformers";
     tag = "v${finalAttrs.version}";
-    hash = "sha256-xf5ujZH7OH81ofavytI/Zd0PCkRf6rIoXzWI9kUjoDE=";
+    hash = "sha256-VZu50DVuU0P7o3+iKVWougui7nWSrnP/eza0Rqtt7ZU=";
   };
 
   build-system = [ setuptools ];
@@ -58,9 +58,11 @@ buildPythonPackage (finalAttrs: {
   ];
 
   optional-dependencies = {
-    image = [
-      pillow
-    ];
+    image = transformers.optional-dependencies.vision;
+    inherit (transformers.optional-dependencies)
+      audio
+      video
+      ;
     train = [
       accelerate
       datasets
@@ -115,12 +117,14 @@ buildPythonPackage (finalAttrs: {
     "test_router_with_trainer"
     "test_router_with_trainer_without_router_mapping"
     "test_save_and_load"
+    "test_simple"
     "test_simple_encode"
     "test_tokenize"
     "test_train_stsb"
     "test_trainer"
     "test_trainer_invalid_column_names"
     "test_trainer_multi_dataset_errors"
+    "test_unsupported_modality"
     "test_valid_initialization_no_warnings"
     "test_valid_initialization_with_weights"
     "test_weights_length_mismatch_raises_error"
@@ -152,31 +156,26 @@ buildPythonPackage (finalAttrs: {
 
   disabledTestPaths = [
     # Tests require network access
-    "tests/cross_encoder/test_cross_encoder.py"
+    "tests/base/modules/"
+    "tests/base/test_model.py"
+    "tests/base/test_model_card.py"
+    "tests/cross_encoder/evaluation/test_reranking.py"
+    "tests/cross_encoder/test_model.py"
     "tests/cross_encoder/test_model_card.py"
     "tests/cross_encoder/test_train_stsb.py"
-    "tests/evaluation/test_information_retrieval_evaluator.py"
-    "tests/sparse_encoder/models/test_csr.py"
-    "tests/sparse_encoder/models/test_sparse_static_embedding.py"
+    "tests/sentence_transformer/test_compute_embeddings.py"
+    "tests/sentence_transformer/test_model.py"
+    "tests/sentence_transformer/test_model_card.py"
+    "tests/sentence_transformer/test_model_card_data.py"
+    "tests/sparse_encoder/modules/test_csr.py"
+    "tests/sparse_encoder/modules/test_sparse_static_embedding.py"
+    "tests/sparse_encoder/test_model.py"
     "tests/sparse_encoder/test_model_card.py"
     "tests/sparse_encoder/test_opensearch_models.py"
     "tests/sparse_encoder/test_pretrained.py"
-    "tests/sparse_encoder/test_sparse_encoder.py"
-    "tests/test_compute_embeddings.py"
-    "tests/test_model_card.py"
-    "tests/test_model_card_data.py"
-    "tests/test_multi_process.py"
-    "tests/test_pretrained_stsb.py"
-    "tests/test_sentence_transformer.py"
-    "tests/test_train_stsb.py"
     "tests/util/test_hard_negatives.py"
   ];
 
-  # Sentence-transformer needs a writable hf_home cache
-  postInstall = ''
-    export HF_HOME=$(mktemp -d)
-  '';
-
   meta = {
     description = "Multilingual Sentence & Image Embeddings with BERT";
     homepage = "https://github.com/huggingface/sentence-transformers";