From 949a2a78b2afc5d94b6103f46aa93b1de1065e8a Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Wed, 10 Sep 2025 16:56:20 +0200 Subject: [PATCH 1/4] clementine: use `lib.cmake{Bool,Feature}` --- pkgs/applications/audio/clementine/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/audio/clementine/default.nix b/pkgs/applications/audio/clementine/default.nix index eba658a1435a..90408ce536ee 100644 --- a/pkgs/applications/audio/clementine/default.nix +++ b/pkgs/applications/audio/clementine/default.nix @@ -119,9 +119,9 @@ stdenv.mkDerivation (finalAttrs: { ''; cmakeFlags = [ - "-DFORCE_GIT_REVISION=1.3.1" - "-DUSE_SYSTEM_PROJECTM=ON" - "-DSPOTIFY_BLOB=OFF" + (lib.cmakeFeature "FORCE_GIT_REVISION" "1.3.1") + (lib.cmakeBool "USE_SYSTEM_PROJECTM" true) + (lib.cmakeBool "SPOTIFY_BLOB" false) ]; dontWrapQtApps = true; From 897418fed39305c3bb91aaf6e9c2e5a06a3cbf78 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Wed, 10 Sep 2025 16:58:29 +0200 Subject: [PATCH 2/4] clementine: remove obsolete parens --- pkgs/applications/audio/clementine/default.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/audio/clementine/default.nix b/pkgs/applications/audio/clementine/default.nix index 90408ce536ee..40f9779f386f 100644 --- a/pkgs/applications/audio/clementine/default.nix +++ b/pkgs/applications/audio/clementine/default.nix @@ -96,14 +96,14 @@ stdenv.mkDerivation (finalAttrs: { ] # gst_plugins needed for setup-hooks ++ gst_plugins - ++ lib.optionals (withIpod) [ + ++ lib.optionals withIpod [ libgpod libplist usbmuxd ] - ++ lib.optionals (withMTP) [ libmtp ] - ++ lib.optionals (withCD) [ libcdio ] - ++ lib.optionals (withCloud) [ sparsehash ]; + ++ lib.optionals withMTP [ libmtp ] + ++ lib.optionals withCD [ libcdio ] + ++ lib.optionals withCloud [ sparsehash ]; postPatch = '' sed -i src/CMakeLists.txt \ From 3c31a37b908a639789a3a4c5e417857290a0f3ce Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Wed, 10 Sep 2025 16:59:06 +0200 Subject: [PATCH 3/4] clementine: add `meta.mainProgram` --- pkgs/applications/audio/clementine/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/applications/audio/clementine/default.nix b/pkgs/applications/audio/clementine/default.nix index 40f9779f386f..7e37db4ba359 100644 --- a/pkgs/applications/audio/clementine/default.nix +++ b/pkgs/applications/audio/clementine/default.nix @@ -136,6 +136,7 @@ stdenv.mkDerivation (finalAttrs: { description = "Multiplatform music player"; license = lib.licenses.gpl3Plus; platforms = lib.platforms.linux; + mainProgram = "clementine"; maintainers = with lib.maintainers; [ ttuegel ]; }; }) From e70f84411387c75129acbf45a9e89b68665117ff Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Wed, 10 Sep 2025 17:00:06 +0200 Subject: [PATCH 4/4] clementine: replace `util-linux` with `util-linuxMinimal` --- pkgs/applications/audio/clementine/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/audio/clementine/default.nix b/pkgs/applications/audio/clementine/default.nix index 7e37db4ba359..169d0b34a820 100644 --- a/pkgs/applications/audio/clementine/default.nix +++ b/pkgs/applications/audio/clementine/default.nix @@ -32,7 +32,7 @@ config, wrapQtAppsHook, gst_plugins, - util-linux, + util-linuxMinimal, libunwind, libselinux, elfutils, @@ -62,7 +62,7 @@ stdenv.mkDerivation (finalAttrs: { cmake pkg-config wrapQtAppsHook - util-linux + util-linuxMinimal libunwind libselinux elfutils