From 9e93bb5054e38e1028de935262fb55730aabe853 Mon Sep 17 00:00:00 2001
From: John Titor <50095635+JohnRTitor@users.noreply.github.com>
Date: Sat, 4 Jan 2025 00:17:49 +0530
Subject: [PATCH] jack1: 0.125.0 -> 0.126.0

celt should be pinned to celt_0_7 for compatibility reasons.
Specifically definition of celt_encoder_create, celt_decoder_create functions changed in laters of celt.
This wasn't required in GCC_13 or older because the compiler would ignore it and print just an incompatible pointer to int conversion warning.

Additionally version bumping of jack1 fixes another bug with port_rename_callback definition.
This currently fixes build failure in master.

Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
---
 pkgs/misc/jackaudio/jack1.nix | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pkgs/misc/jackaudio/jack1.nix b/pkgs/misc/jackaudio/jack1.nix
index 8d30e863fb9a..fa31d8ae5fbb 100644
--- a/pkgs/misc/jackaudio/jack1.nix
+++ b/pkgs/misc/jackaudio/jack1.nix
@@ -9,7 +9,7 @@
   db ? null,
   libuuid ? null,
   libffado ? null,
-  celt ? null,
+  celt_0_7 ? null,
 
   testers,
 }:
@@ -22,15 +22,15 @@ let
   optDb = shouldUsePkg db;
   optLibuuid = shouldUsePkg libuuid;
   optLibffado = shouldUsePkg libffado;
-  optCelt = shouldUsePkg celt;
+  optCelt = shouldUsePkg celt_0_7;
 in
 stdenv.mkDerivation (finalAttrs: {
   pname = "jack1";
-  version = "0.125.0";
+  version = "0.126.0";
 
   src = fetchurl {
-    url = "https://jackaudio.org/downloads/jack-audio-connection-kit-${finalAttrs.version}.tar.gz";
-    sha256 = "0i6l25dmfk2ji2lrakqq9icnwjxklgcjzzk65dmsff91z2zva5rm";
+    url = "https://github.com/jackaudio/jack1/releases/download/${finalAttrs.version}/jack1-${finalAttrs.version}.tar.gz";
+    hash = "sha256-eykOnce5JirDKNQe74DBBTyXAT76y++jBHfLmypUReo=";
   };
 
   configureFlags = [