From d01101d8e2b2cec49906c129df48517586c8de65 Mon Sep 17 00:00:00 2001 From: Adam Dinwoodie Date: Sat, 30 May 2026 16:36:30 +0100 Subject: [PATCH] git: use finalAttrs for doInstallCheck config For easier overriding with `git.override` or `git.overrideAttrs`, determine whether configuration related to running the install checks is present based on whether the install checks are actually being run, not on the function argument which may not be the same. --- pkgs/by-name/gi/git/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/gi/git/package.nix b/pkgs/by-name/gi/git/package.nix index fa7bcc7cd054..072fe282a3e3 100644 --- a/pkgs/by-name/gi/git/package.nix +++ b/pkgs/by-name/gi/git/package.nix @@ -157,7 +157,7 @@ stdenv.mkDerivation (finalAttrs: { substituteInPlace contrib/credential/libsecret/Makefile \ --replace-fail 'pkg-config' "$PKG_CONFIG" '' - + lib.optionalString doInstallCheck '' + + lib.optionalString finalAttrs.doInstallCheck '' # ensure we are using the correct shell when executing the test scripts patchShebangs t/*.sh ''