From 9cde368b4ca0da1979ab3454b0c1dca64c69a2e5 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Fri, 8 Aug 2025 18:51:04 +0200 Subject: [PATCH] Revert "workflows/eval: disable swap" This reverts commit f2648b263b69aecca529c14fd5441503850a7c0d. While the idea to never use swap was fine, in practice this meant that when nix ran OOM, some other process was killed instead. This lead to the job not being possible to be cancelled anymore and thus needing to timeout, before subsequent jobs could be scheduled. This can take up to 6 hours for GitHub Actions by default. Re-enabling the swap file to catch this case more gracefully. It's still the goal to never actually *use* the swap file during Eval and just a safeguard. Keeping the changed chunkSize and not reverting it - this makes it slightly less likely to hit the swap file when running with Lix. --- .github/workflows/eval.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/eval.yml b/.github/workflows/eval.yml index 805f8572cf15..3643c2340b83 100644 --- a/.github/workflows/eval.yml +++ b/.github/workflows/eval.yml @@ -32,11 +32,16 @@ jobs: outputs: targetRunId: ${{ steps.targetRunId.outputs.targetRunId }} steps: - # We'd rather fail than run slow eval on swap. - # Failing allows us to adjust the chunkSize to remain fast. - - name: Disable swap + # This is not supposed to be used and just acts as a fallback. + # Without swap, when Eval runs OOM, it will fail badly with a + # job that is sometimes not interruptible anymore. + # If Eval starts swapping, decrease chunkSize to keep it fast. + - name: Enable swap run: | - sudo swapoff -a + sudo fallocate -l 10G /swap + sudo chmod 600 /swap + sudo mkswap /swap + sudo swapon /swap - name: Check out the PR at the test merge commit uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2