From 7131d1832c0bcf3d9a20f1200105fe6519b714e9 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Wed, 14 Dec 2022 14:25:10 +0100 Subject: [PATCH 1/2] gnome.mutter: Drop unneeded patch This is not necessary since the 43.2 bump: https://github.com/NixOS/nixpkgs/commit/3933114462c6a979ce62acf3f7e2d20c3bc52f29 --- pkgs/desktops/gnome/core/mutter/default.nix | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/pkgs/desktops/gnome/core/mutter/default.nix b/pkgs/desktops/gnome/core/mutter/default.nix index 48320f7100b6..8cec010cf53c 100644 --- a/pkgs/desktops/gnome/core/mutter/default.nix +++ b/pkgs/desktops/gnome/core/mutter/default.nix @@ -65,16 +65,6 @@ let self = stdenv.mkDerivation rec { url = "https://gitlab.gnome.org/GNOME/mutter/-/commit/285a5a4d54ca83b136b787ce5ebf1d774f9499d5.patch"; sha256 = "/npUE3idMSTVlFptsDpZmGWjZ/d2gqruVlJKq4eF4xU="; }) - - # Revert clutter optimization causing issues on X11 - # https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2667 - # Will be replaced with a proper fix in 43.2 - # https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6054 - (fetchpatch { - url = "https://gitlab.gnome.org/GNOME/mutter/-/commit/7e7a639cc5132cf3355e861235f325540fe56548.patch"; - sha256 = "NYoKCRh5o1Q15c11a79Hk5tGKq/jOa+e6GpgBjPEepo="; - revert = true; - }) ]; mesonFlags = [ From 6a108b2f761dd5cc481852acb172804db20a56f8 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Wed, 14 Dec 2022 14:30:20 +0100 Subject: [PATCH 2/2] gnome.mutter: use finalAttrs pattern This will ensure the references to self get updated when using overrideAttrs. --- pkgs/desktops/gnome/core/mutter/default.nix | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/pkgs/desktops/gnome/core/mutter/default.nix b/pkgs/desktops/gnome/core/mutter/default.nix index 8cec010cf53c..ed7bb388d85e 100644 --- a/pkgs/desktops/gnome/core/mutter/default.nix +++ b/pkgs/desktops/gnome/core/mutter/default.nix @@ -47,14 +47,14 @@ , wayland-protocols }: -let self = stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "mutter"; version = "43.2"; outputs = [ "out" "dev" "man" "devdoc" ]; src = fetchurl { - url = "mirror://gnome/sources/mutter/${lib.versions.major version}/${pname}-${version}.tar.xz"; + url = "mirror://gnome/sources/mutter/${lib.versions.major finalAttrs.version}/mutter-${finalAttrs.version}.tar.xz"; sha256 = "/S63B63DM8wnevhoXlzzkTXhxNeYofnQXojkU9w+u4Q="; }; @@ -150,12 +150,12 @@ let self = stdenv.mkDerivation rec { separateDebugInfo = true; passthru = { - libdir = "${self}/lib/mutter-11"; + libdir = "${finalAttrs.finalPackage}/lib/mutter-11"; tests = { libdirExists = runCommand "mutter-libdir-exists" {} '' - if [[ ! -d ${self.libdir} ]]; then - echo "passthru.libdir should contain a directory, “${self.libdir}” is not one." + if [[ ! -d ${finalAttrs.finalPackage.libdir} ]]; then + echo "passthru.libdir should contain a directory, “${finalAttrs.finalPackage.libdir}” is not one." exit 1 fi touch $out @@ -163,8 +163,8 @@ let self = stdenv.mkDerivation rec { }; updateScript = gnome.updateScript { - packageName = pname; - attrPath = "gnome.${pname}"; + packageName = "mutter"; + attrPath = "gnome.mutter"; }; }; @@ -175,5 +175,4 @@ let self = stdenv.mkDerivation rec { maintainers = teams.gnome.members; platforms = platforms.linux; }; -}; -in self +})