From 6a95f285698291fce7c3bcb325b388d609b372ab Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Sun, 19 Jan 2025 03:05:24 +0900 Subject: [PATCH 1/3] go-task: 3.40.1 -> 3.41.0 Changelog: https://github.com/go-task/task/blob/v3.41.0/CHANGELOG.md?plain=1#L3-L27 --- pkgs/by-name/go/go-task/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/go/go-task/package.nix b/pkgs/by-name/go/go-task/package.nix index 662ab8d64db9..a9c55132e62b 100644 --- a/pkgs/by-name/go/go-task/package.nix +++ b/pkgs/by-name/go/go-task/package.nix @@ -11,16 +11,16 @@ buildGoModule rec { pname = "go-task"; - version = "3.40.1"; + version = "3.41.0"; src = fetchFromGitHub { owner = "go-task"; repo = "task"; tag = "v${version}"; - hash = "sha256-jQKPTKEzTfzqPlNlKFMduaAhvDsogRv3vCGtZ4KP/O4="; + hash = "sha256-yJ9XTCS0BK+pcQvcbGR2ixwPODJKdfQnHgB1QoTFhzA="; }; - vendorHash = "sha256-bw9NaJOMMKcKth0hRqNq8mqib/5zLpjComo0oj22A/U="; + vendorHash = "sha256-DR9G+I6PYk8jrR0CZiPqtuULTMekATNSLjyHACOmlbk="; doCheck = false; From 80f22115321d8848ada242b7e924a6c27f8fad8a Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Sun, 19 Jan 2025 03:10:52 +0900 Subject: [PATCH 2/3] go-task: prefer versionCheckHook rather than testers.testVersion https://github.com/NixOS/nixpkgs/blob/bd352cd67834c983d69adf4080d225dbe28f99ba/doc/stdenv/passthru.chapter.md?plain=1#L84 --- pkgs/by-name/go/go-task/package.nix | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/pkgs/by-name/go/go-task/package.nix b/pkgs/by-name/go/go-task/package.nix index a9c55132e62b..e4d07822e385 100644 --- a/pkgs/by-name/go/go-task/package.nix +++ b/pkgs/by-name/go/go-task/package.nix @@ -4,9 +4,8 @@ buildGoModule, fetchFromGitHub, installShellFiles, - testers, nix-update-script, - go-task, + versionCheckHook, }: buildGoModule rec { @@ -47,15 +46,14 @@ buildGoModule rec { --zsh <($out/bin/task --completion zsh) ''; - passthru = { - tests = { - version = testers.testVersion { - package = go-task; - }; - }; + nativeInstallCheckInputs = [ + versionCheckHook + ]; + doInstallCheck = true; + versionCheckProgram = "${placeholder "out"}/bin/task"; + versionCheckProgramArg = [ "--version" ]; - updateScript = nix-update-script { }; - }; + passthru.updateScript = nix-update-script { }; meta = with lib; { homepage = "https://taskfile.dev/"; From bda8571c1695ceef06c27e924793c328472c020d Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Sun, 19 Jan 2025 03:11:34 +0900 Subject: [PATCH 3/3] go-task: enable doCheck --- pkgs/by-name/go/go-task/package.nix | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkgs/by-name/go/go-task/package.nix b/pkgs/by-name/go/go-task/package.nix index e4d07822e385..fe1d1bf60921 100644 --- a/pkgs/by-name/go/go-task/package.nix +++ b/pkgs/by-name/go/go-task/package.nix @@ -21,8 +21,6 @@ buildGoModule rec { vendorHash = "sha256-DR9G+I6PYk8jrR0CZiPqtuULTMekATNSLjyHACOmlbk="; - doCheck = false; - nativeBuildInputs = [ installShellFiles ]; subPackages = [ "cmd/task" ];