gador/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib: deprecate fromHexString on dodgy inputs (#434218)

Browse Source
This commit is contained in:
Emily
2025-08-17 17:17:43 +01:00
committed by GitHub
parent a6d8fcda4f 3c7d67da23
commit 922b6476c5
2 changed files with 20 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
lib/tests/misc.nix
View File

@@ -392,35 +392,21 @@ runTests {
expected = 9223372036854775807;
};
testFromHexStringLeadingZeroes = {
expr = fromHexString "00ffffffffffffff";
expected = 72057594037927935;
};
testFromHexStringWithPrefix = {
expr = fromHexString "0Xf";
expr = fromHexString "0xf";
expected = 15;
};
# FIXME: This might be bad and should potentially be deprecated.
testFromHexStringQuestionableMixedCase = {
testFromHexStringMixedCase = {
expr = fromHexString "eEeEe";
expected = 978670;
};
# FIXME: This is probably bad and should potentially be deprecated.
testFromHexStringQuestionableUnderscore = {
expr = fromHexString "F_f";
expected = 255;
};
# FIXME: This is definitely bad and should be deprecated.
testFromHexStringBadComment = {
expr = fromHexString "0 # oops";
expected = 0;
};
# FIXME: Oh my god.
testFromHexStringAwfulInjection = {
expr = fromHexString "1\nwhoops = {}";
expected = 1;
};
testToBaseDigits = {
expr = toBaseDigits 2 6;
expected = [