From b1b3f87d63c9ed6f0e22f0ec0670d281a32f10a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 2 May 2022 12:01:30 +0200 Subject: [PATCH 1/5] htop: remove with lib over entire file --- pkgs/tools/system/htop/default.nix | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/pkgs/tools/system/htop/default.nix b/pkgs/tools/system/htop/default.nix index 26d10d1278da..7024fdfb0cd2 100644 --- a/pkgs/tools/system/htop/default.nix +++ b/pkgs/tools/system/htop/default.nix @@ -5,8 +5,6 @@ , systemdSupport ? stdenv.isLinux, systemd }: -with lib; - assert systemdSupport -> stdenv.isLinux; stdenv.mkDerivation rec { @@ -23,25 +21,25 @@ stdenv.mkDerivation rec { nativeBuildInputs = [ autoreconfHook ]; buildInputs = [ ncurses ] - ++ optional stdenv.isDarwin IOKit - ++ optional sensorsSupport lm_sensors - ++ optional systemdSupport systemd + ++ lib.optional stdenv.isDarwin IOKit + ++ lib.optional sensorsSupport lm_sensors + ++ lib.optional systemdSupport systemd ; configureFlags = [ "--enable-unicode" "--sysconfdir=/etc" ] - ++ optional sensorsSupport "--with-sensors" + ++ lib.optional sensorsSupport "--with-sensors" ; postFixup = let - optionalPatch = pred: so: optionalString pred "patchelf --add-needed ${so} $out/bin/htop"; + optionalPatch = pred: so: lib.optionalString pred "patchelf --add-needed ${so} $out/bin/htop"; in '' ${optionalPatch sensorsSupport "${lm_sensors}/lib/libsensors.so"} ${optionalPatch systemdSupport "${systemd}/lib/libsystemd.so"} ''; - meta = { + meta = with lib; { description = "An interactive process viewer for Linux"; homepage = "https://htop.dev"; license = licenses.gpl2Only; From 9f0746f997cbbadad1f69ccd97f89430f15daecb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 2 May 2022 12:01:54 +0200 Subject: [PATCH 2/5] htop: make changelog url better clickable --- pkgs/tools/system/htop/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/tools/system/htop/default.nix b/pkgs/tools/system/htop/default.nix index 7024fdfb0cd2..74f8095a681f 100644 --- a/pkgs/tools/system/htop/default.nix +++ b/pkgs/tools/system/htop/default.nix @@ -45,6 +45,6 @@ stdenv.mkDerivation rec { license = licenses.gpl2Only; platforms = platforms.all; maintainers = with maintainers; [ rob relrod ]; - changelog = "https://github.com/htop-dev/${pname}/blob/${version}/ChangeLog"; + changelog = "https://github.com/htop-dev/htop/blob/${version}/ChangeLog"; }; } From 6022fd57b2a98cc7da139c998bcf4fd84029e0b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 2 May 2022 12:02:09 +0200 Subject: [PATCH 3/5] htop: add SuperSandro2000 as maintainer --- pkgs/tools/system/htop/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/tools/system/htop/default.nix b/pkgs/tools/system/htop/default.nix index 74f8095a681f..c074b075d232 100644 --- a/pkgs/tools/system/htop/default.nix +++ b/pkgs/tools/system/htop/default.nix @@ -44,7 +44,7 @@ stdenv.mkDerivation rec { homepage = "https://htop.dev"; license = licenses.gpl2Only; platforms = platforms.all; - maintainers = with maintainers; [ rob relrod ]; + maintainers = with maintainers; [ rob relrod SuperSandro2000 ]; changelog = "https://github.com/htop-dev/htop/blob/${version}/ChangeLog"; }; } From db312071f9413048769e23fc9f9117235b00eae2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 2 May 2022 12:03:07 +0200 Subject: [PATCH 4/5] htop: 3.1.2 -> 3.2.0 --- pkgs/tools/system/htop/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/tools/system/htop/default.nix b/pkgs/tools/system/htop/default.nix index c074b075d232..823d20630eb3 100644 --- a/pkgs/tools/system/htop/default.nix +++ b/pkgs/tools/system/htop/default.nix @@ -9,13 +9,13 @@ assert systemdSupport -> stdenv.isLinux; stdenv.mkDerivation rec { pname = "htop"; - version = "3.1.2"; + version = "3.2.0"; src = fetchFromGitHub { owner = "htop-dev"; repo = pname; rev = version; - sha256 = "sha256-RKYS8UYZTVKMR/3DG31eqkG4knPRl8WXsZU/XGmGmAg="; + sha256 = "sha256-p/lc7G/XFllulXrM47mPE6W5vVuoi4uXB8To36PIgZo="; }; nativeBuildInputs = [ autoreconfHook ]; From 1fddd7401aa6667dd19780a3d041e9a7ea673c31 Mon Sep 17 00:00:00 2001 From: Sandro Date: Mon, 2 May 2022 22:43:07 +0200 Subject: [PATCH 5/5] htop: remove linux only hint from description because it also works on darwin --- pkgs/tools/system/htop/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/tools/system/htop/default.nix b/pkgs/tools/system/htop/default.nix index 823d20630eb3..47ebee52fe16 100644 --- a/pkgs/tools/system/htop/default.nix +++ b/pkgs/tools/system/htop/default.nix @@ -40,7 +40,7 @@ stdenv.mkDerivation rec { ''; meta = with lib; { - description = "An interactive process viewer for Linux"; + description = "An interactive process viewer"; homepage = "https://htop.dev"; license = licenses.gpl2Only; platforms = platforms.all;