From f13547a8cbf173de7f9bda40a6c459f37cf72519 Mon Sep 17 00:00:00 2001
From: Jeremy Schlatter <jeremy@jeremyschlatter.com>
Date: Mon, 10 Jun 2024 12:21:59 -0700
Subject: [PATCH] sandboxfs: remove

sandboxfs was an experiment to increase sandboxing performance in bazel,
but it never reached a stable release.

The author of sandboxfs left Google in 2020 and there have been no
updates to it since then.

bazel dropped sandboxfs in the bazel 7 release. To quote their release
notes:

    The sandboxfs sandboxing strategy is removed. It hadn't been
    maintained for a long time, it didn't work for most users and it was
    not consistently faster while being complex to set up. sandboxfs
    performance is heavily dependent on the specific setup (setup costs
    are lower, but you have to pay a penalty for the use of each input)
    and there are scenarios where it is faster and scenarios where it is
    slower. Overall it is not worth its weight.

    - https://github.com/bazelbuild/bazel/commit/217fafe2b492de7349547cc3be2b9eef38628055
---
 pkgs/tools/filesystems/sandboxfs/default.nix | 35 --------------------
 pkgs/top-level/aliases.nix                   |  1 +
 pkgs/top-level/all-packages.nix              |  2 --
 3 files changed, 1 insertion(+), 37 deletions(-)
 delete mode 100644 pkgs/tools/filesystems/sandboxfs/default.nix

diff --git a/pkgs/tools/filesystems/sandboxfs/default.nix b/pkgs/tools/filesystems/sandboxfs/default.nix
deleted file mode 100644
index 3f306a904fd8..000000000000
--- a/pkgs/tools/filesystems/sandboxfs/default.nix
+++ /dev/null
@@ -1,35 +0,0 @@
-{ stdenv
-, lib
-, rustPlatform
-, fetchCrate
-, pkg-config
-, installShellFiles
-, fuse
-}:
-
-rustPlatform.buildRustPackage rec {
-  pname = "sandboxfs";
-  version = "0.2.0";
-
-  src = fetchCrate {
-    inherit pname version;
-    sha256 = "sha256-nrrkFYAf7HqaGFruolNTkXzy4ID6/vipxd+fOCKYARM=";
-  };
-
-  cargoSha256 = "sha256-izz10ePmEt2xxOyR4NODIMAcY9d4ODo677mq+DVf4RI=";
-
-  nativeBuildInputs = [ pkg-config installShellFiles ];
-
-  buildInputs = [ fuse ];
-
-  postInstall = "installManPage man/sandboxfs.1";
-
-  meta = with lib; {
-    broken = stdenv.isDarwin;
-    description = "Virtual file system for sandboxing";
-    homepage = "https://github.com/bazelbuild/sandboxfs";
-    license = with licenses; [ asl20 ];
-    maintainers = with maintainers; [ jeremyschlatter ];
-    mainProgram = "sandboxfs";
-  };
-}
diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix
index cbb5d593f1ae..dda87ccd84cf 100644
--- a/pkgs/top-level/aliases.nix
+++ b/pkgs/top-level/aliases.nix
@@ -1182,6 +1182,7 @@ mapAliases ({
   ### S ###
 
   s2n = s2n-tls; # Added 2021-03-03
+  sandboxfs = throw "'sandboxfs' has been removed due to being unmaintained, consider using linux namespaces for sandboxing instead"; # Added 2024-06-06
   sane-backends-git = sane-backends; # Added 2021-02-19
   scantailor = scantailor-advanced; # Added 2022-05-26
   schildichat-web = throw ''
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 169e0f6bc72c..ee187a63a63e 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -12690,8 +12690,6 @@ with pkgs;
 
   sanctity = callPackage ../tools/misc/sanctity { };
 
-  sandboxfs = callPackage ../tools/filesystems/sandboxfs { };
-
   sanjuuni = callPackage ../tools/graphics/sanjuuni { };
 
   sasquatch = callPackage ../tools/filesystems/sasquatch { };