From 6e8b5e78afd44204f4f8cf4c2abfcb872206e8c4 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Mon, 12 Jan 2026 09:46:03 -0800 Subject: [PATCH 1/2] python3Packages.fickling: apply finalAttrs fix --- .../development/python-modules/fickling/default.nix | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/pkgs/development/python-modules/fickling/default.nix b/pkgs/development/python-modules/fickling/default.nix index 88a2bab3ea95..3a12f52a795f 100644 --- a/pkgs/development/python-modules/fickling/default.nix +++ b/pkgs/development/python-modules/fickling/default.nix @@ -10,7 +10,7 @@ torchvision, }: -buildPythonPackage rec { +buildPythonPackage (finalAttrs: { pname = "fickling"; version = "0.1.6"; pyproject = true; @@ -18,7 +18,7 @@ buildPythonPackage rec { src = fetchFromGitHub { owner = "trailofbits"; repo = "fickling"; - tag = "v${version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-p2XkHKqheVHqLTQKmUApiYH7NIaHc091B/TjiCDYWtA="; }; @@ -40,7 +40,10 @@ buildPythonPackage rec { ]; }; - nativeCheckInputs = [ pytestCheckHook ] ++ lib.concatAttrValues optional-dependencies; + nativeCheckInputs = [ + pytestCheckHook + ] + ++ lib.concatAttrValues finalAttrs.passthru.optional-dependencies; disabledTestPaths = [ # https://github.com/trailofbits/fickling/issues/162 @@ -53,8 +56,8 @@ buildPythonPackage rec { meta = { description = "Python pickling decompiler and static analyzer"; homepage = "https://github.com/trailofbits/fickling"; - changelog = "https://github.com/trailofbits/fickling/releases/tag/${src.tag}"; + changelog = "https://github.com/trailofbits/fickling/releases/tag/${finalAttrs.src.tag}"; license = lib.licenses.lgpl3Plus; maintainers = with lib.maintainers; [ sarahec ]; }; -} +}) From e8bfb88ec5cc6f919735e7d701afa1b7e91d413f Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Mon, 12 Jan 2026 10:00:47 -0800 Subject: [PATCH 2/2] python3Packages.fickling: 0.1.6 -> 0.1.7 CHANGELOG: https://github.com/trailofbits/fickling/releases/tag/v0.1.7 DIFF: https://github.com/trailofbits/fickling/compare/v0.1.6...v0.1.7 --- pkgs/development/python-modules/fickling/default.nix | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/pkgs/development/python-modules/fickling/default.nix b/pkgs/development/python-modules/fickling/default.nix index 3a12f52a795f..287b4a0d1519 100644 --- a/pkgs/development/python-modules/fickling/default.nix +++ b/pkgs/development/python-modules/fickling/default.nix @@ -2,6 +2,7 @@ lib, buildPythonPackage, fetchFromGitHub, + pythonOlder, hatchling, numpy, pytestCheckHook, @@ -12,14 +13,14 @@ buildPythonPackage (finalAttrs: { pname = "fickling"; - version = "0.1.6"; + version = "0.1.7"; pyproject = true; src = fetchFromGitHub { owner = "trailofbits"; repo = "fickling"; tag = "v${finalAttrs.version}"; - hash = "sha256-p2XkHKqheVHqLTQKmUApiYH7NIaHc091B/TjiCDYWtA="; + hash = "sha256-uirVOJ6CI7gBu9lOoPtpjUZeBmIhBMI0tjSDI/ASy7w="; }; build-system = [ @@ -45,11 +46,8 @@ buildPythonPackage (finalAttrs: { ] ++ lib.concatAttrValues finalAttrs.passthru.optional-dependencies; - disabledTestPaths = [ - # https://github.com/trailofbits/fickling/issues/162 - # AttributeError: module 'numpy.lib.format' has no attribute... - "test/test_polyglot.py" - ]; + # Tests fail upstream in pytorch under python 3.14 + doCheck = pythonOlder "3.14"; pythonImportsCheck = [ "fickling" ];