From 8dbe11b490ecc01c599c93e913cfb2eb922eedad Mon Sep 17 00:00:00 2001 From: Kylie McClain Date: Thu, 13 Nov 2025 22:54:31 -0500 Subject: [PATCH] kdePackages.elisa: Allow building without libVLC Elisa supports using qtmultimedia's own facilities for audio playback, rather than using Elisa's own custom VLC-based backend, which it will prefer if available at build time. qtmultimedia's default backend on most platforms is ffmpeg, and anecdotally, it's giving me better performance than Elisa's VLC-based backend was. It seems like most distributions build it with libVLC, with the notable exceptions of Fedora, and Gentoo (which of course makes building with VLC user-configurable). --- pkgs/kde/gear/elisa/default.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/kde/gear/elisa/default.nix b/pkgs/kde/gear/elisa/default.nix index ee280ae93198..8eb318cfc0d5 100644 --- a/pkgs/kde/gear/elisa/default.nix +++ b/pkgs/kde/gear/elisa/default.nix @@ -1,14 +1,14 @@ { + lib, mkKdeDerivation, qtmultimedia, libvlc, + + withVLC ? true, }: mkKdeDerivation { pname = "elisa"; - extraBuildInputs = [ - qtmultimedia - libvlc - ]; + extraBuildInputs = [ qtmultimedia ] ++ lib.optional withVLC libvlc; meta.mainProgram = "elisa"; }