From c7a0524379ec4a46a964edcae622897a45536aa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=A9clairevoyant?= <848000+eclairevoyant@users.noreply.github.com> Date: Tue, 9 Dec 2025 01:45:44 -0500 Subject: [PATCH 1/2] nixos/scrutiny: conform to shellcheck --- nixos/modules/services/monitoring/scrutiny.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nixos/modules/services/monitoring/scrutiny.nix b/nixos/modules/services/monitoring/scrutiny.nix index c4212b4d7bd4..f2f494fb25e2 100644 --- a/nixos/modules/services/monitoring/scrutiny.nix +++ b/nixos/modules/services/monitoring/scrutiny.nix @@ -205,6 +205,7 @@ in systemd.services.scrutiny = { description = "Hard Drive S.M.A.R.T Monitoring, Historical Trends & Real World Failure Thresholds"; + enableStrictShellChecks = true; wantedBy = [ "multi-user.target" ]; after = [ "network.target" ] ++ lib.optional cfg.influxdb.enable "influxdb2.service"; wants = lib.optional cfg.influxdb.enable "influxdb2.service"; @@ -217,7 +218,7 @@ in ${genJqSecretsReplacementSnippet cfg.settings "/run/scrutiny/config.yaml"} ''; postStart = '' - for i in $(seq 300); do + for _ in $(seq 300); do if "${lib.getExe pkgs.curl}" --fail --silent --head "http://${cfg.settings.web.listen.host}:${toString cfg.settings.web.listen.port}" >/dev/null; then echo "Scrutiny is ready (port is open)" exit 0 @@ -251,6 +252,7 @@ in systemd = { services.scrutiny-collector = { description = "Scrutiny Collector Service"; + enableStrictShellChecks = true; after = lib.optional cfg.enable "scrutiny.service"; wants = lib.optional cfg.enable "scrutiny.service"; environment = { From 4bd6297009e2fe1767b17377eaf23ae35b2f03cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=A9clairevoyant?= <848000+eclairevoyant@users.noreply.github.com> Date: Tue, 9 Dec 2025 01:45:52 -0500 Subject: [PATCH 2/2] nixos/scrutiny: remove dead code --- nixos/modules/services/monitoring/scrutiny.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/nixos/modules/services/monitoring/scrutiny.nix b/nixos/modules/services/monitoring/scrutiny.nix index f2f494fb25e2..1c3cbd9a7a3a 100644 --- a/nixos/modules/services/monitoring/scrutiny.nix +++ b/nixos/modules/services/monitoring/scrutiny.nix @@ -6,7 +6,6 @@ ... }: let - inherit (lib) maintainers; inherit (lib.meta) getExe; inherit (lib.modules) mkIf mkMerge; inherit (lib.options)