From d86dc7c016a95e9d6f2133db317ba505371b0a88 Mon Sep 17 00:00:00 2001 From: Bobby Rong Date: Wed, 16 Aug 2023 21:40:34 +0800 Subject: [PATCH 1/2] nixosTests.pantheon: Ensure the test fails when gala coredumps It can be possible that pgrep failed to catch this. See the GNOME 45 PR. --- nixos/tests/pantheon.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/nixos/tests/pantheon.nix b/nixos/tests/pantheon.nix index 653fcc6edad1..dee6964644c5 100644 --- a/nixos/tests/pantheon.nix +++ b/nixos/tests/pantheon.nix @@ -60,6 +60,9 @@ import ./make-test-python.nix ({ pkgs, lib, ...} : with subtest("Open elementary terminal"): machine.execute("su - ${user.name} -c 'DISPLAY=:0 io.elementary.terminal >&2 &'") machine.wait_for_window("io.elementary.terminal") + + with subtest("Check if gala has ever coredumped"): + machine.fail("coredumpctl --json=short | grep gala") machine.sleep(20) machine.screenshot("screen") ''; From ba96b6bdaaa276fbb6d0007a7b196017ac169077 Mon Sep 17 00:00:00 2001 From: Bobby Rong Date: Wed, 16 Aug 2023 23:06:50 +0800 Subject: [PATCH 2/2] nixosTests.budgie: Re-add checks for budgie-wm This is the shell of the desktop, it is still a good idea to do something with it. --- nixos/tests/budgie.nix | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/nixos/tests/budgie.nix b/nixos/tests/budgie.nix index 34ee1e303de9..19d9b2bd0bed 100644 --- a/nixos/tests/budgie.nix +++ b/nixos/tests/budgie.nix @@ -52,10 +52,16 @@ import ./make-test-python.nix ({ pkgs, lib, ... }: { machine.wait_for_window("budgie-daemon") machine.wait_until_succeeds("pgrep budgie-panel") machine.wait_for_window("budgie-panel") + # We don't check xwininfo for this one. + # See https://github.com/NixOS/nixpkgs/pull/216737#discussion_r1155312754 + machine.wait_until_succeeds("pgrep budgie-wm") with subtest("Open MATE terminal"): machine.succeed("su - ${user.name} -c 'DISPLAY=:0 mate-terminal >&2 &'") machine.wait_for_window("Terminal") + + with subtest("Check if budgie-wm has ever coredumped"): + machine.fail("coredumpctl --json=short | grep budgie-wm") machine.sleep(20) machine.screenshot("screen") '';