diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix index 7e02c21f4f12..3db1ed59db7a 100644 --- a/pkgs/development/web/nodejs/nodejs.nix +++ b/pkgs/development/web/nodejs/nodejs.nix @@ -414,12 +414,6 @@ let ++ lib.optionals (!lib.versionAtLeast version "22") [ "test-tls-multi-key" ] - ++ lib.optionals (lib.versionAtLeast version "24") [ - # Checks for SQLite's RBU extension, which we don't enable by default. - "test-sqlite" - # Fails with readline error: 'Uncaught Error [ERR_USE_AFTER_CLOSE]: readline was closed', - "test-repl-import-referrer" - ] ++ lib.optionals stdenv.hostPlatform.is32bit [ # utime (actually utimensat) fails with EINVAL on 2038 timestamp "test-fs-utimes-y2K38" diff --git a/pkgs/development/web/nodejs/v24.nix b/pkgs/development/web/nodejs/v24.nix index 4ff7bb3d2ff6..85e78b3b3c77 100644 --- a/pkgs/development/web/nodejs/v24.nix +++ b/pkgs/development/web/nodejs/v24.nix @@ -17,8 +17,8 @@ let in buildNodejs { inherit enableNpm; - version = "24.0.0-rc.3"; - sha256 = "9bbca08fba05f075a20f734ea80b195a4a39218476b60b32db79e1d393fda20b"; + version = "24.0.0"; + sha256 = "914f3f1b03f84a0994d7357f190ff13c038800c693b6c06da2290eb588c82761"; patches = ( if (stdenv.hostPlatform.emulatorAvailable buildPackages) then @@ -51,6 +51,13 @@ buildNodejs { ./node-npm-build-npm-package-logic.patch ./use-correct-env-in-tests.patch ./bin-sh-node-run-v22.patch + + # Can be removed after https://github.com/NixOS/nixpkgs/pull/403958. + (fetchpatch2 { + url = "https://github.com/nodejs/node/commit/9aa57bf8dab2dbfb8b6974fe71d5dbe6daf66244.patch?full_index=1"; + hash = "sha256-k3h8mPgvaIYGAkGmaL+ix7kUnyLw4/PF7wXMAWrPMXo="; + revert = true; + }) ] ++ lib.optionals (!stdenv.buildPlatform.isDarwin) [ # test-icu-env is failing without the reverts