From 867832aa501e98385aa4a2c6cd55af42d69161ef Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Thu, 1 May 2025 08:04:17 +0200 Subject: [PATCH] nixos/gnome: Rename core-utilities option to core-apps To match the upstream BuildStream definition: https://gitlab.gnome.org/GNOME/gnome-build-meta/-/commit/3968975eacddebf034a79b051ccc3616dfb777c8 --- nixos/doc/manual/release-notes/rl-2505.section.md | 1 + .../modules/services/x11/desktop-managers/gnome.md | 4 ++-- .../modules/services/x11/desktop-managers/gnome.nix | 13 ++++++++++--- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/nixos/doc/manual/release-notes/rl-2505.section.md b/nixos/doc/manual/release-notes/rl-2505.section.md index 63d808f044c6..ac8f2a051036 100644 --- a/nixos/doc/manual/release-notes/rl-2505.section.md +++ b/nixos/doc/manual/release-notes/rl-2505.section.md @@ -29,6 +29,7 @@ - `decibels` music player is now installed by default. You can disable it using [](#opt-environment.gnome.excludePackages). - `gnome-shell-extensions` extension collection (which included GNOME Classic extensions, Apps Menu, and User Themes, among others) are no longer installed by default. You can install them again with [](#opt-services.xserver.desktopManager.gnome.sessionPath). - Option [](#opt-services.gnome.core-developer-tools.enable) now also installs `sysprof` and `d-spy`. + - Option `services.gnome.core-utilities.enable` has been renamed to [](#opt-services.gnome.core-apps.enable). Refer to the [GNOME release notes](https://release.gnome.org/48/) for more details. diff --git a/nixos/modules/services/x11/desktop-managers/gnome.md b/nixos/modules/services/x11/desktop-managers/gnome.md index f959c0912652..7f7801305e23 100644 --- a/nixos/modules/services/x11/desktop-managers/gnome.md +++ b/nixos/modules/services/x11/desktop-managers/gnome.md @@ -19,7 +19,7 @@ To enable the GNOME desktop use: While it is not strictly necessary to use GDM as the display manager with GNOME, it is recommended, as some features such as screen lock [might not work](#sec-gnome-faq-can-i-use-lightdm-with-gnome) without it. ::: -The default applications used in NixOS are very minimal, inspired by the defaults used in [gnome-build-meta](https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/40.0/elements/core/meta-gnome-core-utilities.bst). +The default applications used in NixOS are very minimal, inspired by the defaults used in [gnome-build-meta](https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/48.0/elements/core/meta-gnome-core-apps.bst). ### GNOME without the apps {#sec-gnome-without-the-apps} @@ -27,7 +27,7 @@ If you’d like to only use the GNOME desktop and not the apps, you can disable ```nix { - services.gnome.core-utilities.enable = false; + services.gnome.core-apps.enable = false; } ``` diff --git a/nixos/modules/services/x11/desktop-managers/gnome.nix b/nixos/modules/services/x11/desktop-managers/gnome.nix index 5623718bf8d6..6fe467425fc1 100644 --- a/nixos/modules/services/x11/desktop-managers/gnome.nix +++ b/nixos/modules/services/x11/desktop-managers/gnome.nix @@ -84,12 +84,19 @@ in maintainers = lib.teams.gnome.members; }; + imports = [ + (lib.mkRenamedOptionModule + [ "services" "gnome" "core-utilities" "enable" ] + [ "services" "gnome" "core-apps" "enable" ] + ) + ]; + options = { services.gnome = { core-os-services.enable = mkEnableOption "essential services for GNOME3"; core-shell.enable = mkEnableOption "GNOME Shell services"; - core-utilities.enable = mkEnableOption "GNOME core utilities"; + core-apps.enable = mkEnableOption "GNOME core apps"; core-developer-tools.enable = mkEnableOption "GNOME core developer tools"; games.enable = mkEnableOption "GNOME games"; }; @@ -213,7 +220,7 @@ in services.gnome.core-os-services.enable = true; services.gnome.core-shell.enable = true; - services.gnome.core-utilities.enable = mkDefault true; + services.gnome.core-apps.enable = mkDefault true; services.displayManager.sessionPackages = [ pkgs.gnome-session.sessions ]; @@ -405,7 +412,7 @@ in }) # Adapt from https://gitlab.gnome.org/GNOME/gnome-build-meta/-/blob/gnome-48/elements/core/meta-gnome-core-apps.bst - (lib.mkIf serviceCfg.core-utilities.enable { + (lib.mkIf serviceCfg.core-apps.enable { environment.systemPackages = utils.removePackagesByName ( [ pkgs.baobab