From e04a574cff8d3c9a4e75fc9e66fb14043f121385 Mon Sep 17 00:00:00 2001 From: Patrick Hilhorst Date: Mon, 24 May 2021 21:34:28 +0200 Subject: [PATCH 1/2] vscod{e,ium}: allow nixpkgs-update to run nixpkgs-update didn't run the updatescript before, causing issues. This has since been fixed. --- pkgs/applications/editors/vscode/vscode.nix | 3 --- pkgs/applications/editors/vscode/vscodium.nix | 2 -- 2 files changed, 5 deletions(-) diff --git a/pkgs/applications/editors/vscode/vscode.nix b/pkgs/applications/editors/vscode/vscode.nix index 6ae837105a92..672b1aaf096e 100644 --- a/pkgs/applications/editors/vscode/vscode.nix +++ b/pkgs/applications/editors/vscode/vscode.nix @@ -20,9 +20,6 @@ let }.${system}; in callPackage ./generic.nix rec { - # The update script doesn't correctly change the hash for darwin, so please: - # nixpkgs-update: no auto update - # Please backport all compatible updates to the stable release. # This is important for the extension ecosystem. version = "1.56.2"; diff --git a/pkgs/applications/editors/vscode/vscodium.nix b/pkgs/applications/editors/vscode/vscodium.nix index da29daa63599..f542557c384e 100644 --- a/pkgs/applications/editors/vscode/vscodium.nix +++ b/pkgs/applications/editors/vscode/vscodium.nix @@ -28,8 +28,6 @@ let in callPackage ./generic.nix rec { inherit sourceRoot; - # The update script doesn't correctly change the hash for darwin, so please: - # nixpkgs-update: no auto update # Please backport all compatible updates to the stable release. # This is important for the extension ecosystem. From 9674711a573144ba5c533bef38460449296ffec9 Mon Sep 17 00:00:00 2001 From: Patrick Hilhorst Date: Mon, 24 May 2021 21:46:44 +0200 Subject: [PATCH 2/2] vscod{e,ium}: set passthru.updateScript --- pkgs/applications/editors/vscode/generic.nix | 4 ++-- pkgs/applications/editors/vscode/vscode.nix | 2 ++ pkgs/applications/editors/vscode/vscodium.nix | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/editors/vscode/generic.nix b/pkgs/applications/editors/vscode/generic.nix index 8bdfc64d8571..56a81f21febb 100644 --- a/pkgs/applications/editors/vscode/generic.nix +++ b/pkgs/applications/editors/vscode/generic.nix @@ -9,7 +9,7 @@ # Attributes inherit from specific versions , version, src, meta, sourceRoot -, executableName, longName, shortName, pname +, executableName, longName, shortName, pname, updateScript }: let @@ -19,7 +19,7 @@ let inherit pname version src sourceRoot; passthru = { - inherit executableName tests; + inherit executableName tests updateScript; fhs = fhs {}; fhsWithPackages = f: fhs { additionalPkgs = f; }; }; diff --git a/pkgs/applications/editors/vscode/vscode.nix b/pkgs/applications/editors/vscode/vscode.nix index 672b1aaf096e..fd1cb7153ebf 100644 --- a/pkgs/applications/editors/vscode/vscode.nix +++ b/pkgs/applications/editors/vscode/vscode.nix @@ -37,6 +37,8 @@ in sourceRoot = ""; + updateScript = ./update-vscodium.sh; + meta = with lib; { description = '' Open source source code editor developed by Microsoft for Windows, diff --git a/pkgs/applications/editors/vscode/vscodium.nix b/pkgs/applications/editors/vscode/vscodium.nix index f542557c384e..7dadd02a4476 100644 --- a/pkgs/applications/editors/vscode/vscodium.nix +++ b/pkgs/applications/editors/vscode/vscodium.nix @@ -45,6 +45,8 @@ in tests = nixosTests.vscodium; + updateScript = ./update-vscodium.sh; + meta = with lib; { description = '' Open source source code editor developed by Microsoft for Windows,