From c4aa5081f908f20263503c25a8d4d253f3239a67 Mon Sep 17 00:00:00 2001 From: "Matthieu C." <886074+teto@users.noreply.github.com> Date: Fri, 17 Jan 2025 23:00:43 +0100 Subject: [PATCH 1/3] neovim: enable autoconfigure by default It was disabled before. You can still disable by using neovim.overrideAttrs({ autoconfigure = false; }). See the documentation at https://nixos.org/manual/nixpkgs/unstable/#neovim-custom-configuration --- pkgs/applications/editors/neovim/wrapper.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/editors/neovim/wrapper.nix b/pkgs/applications/editors/neovim/wrapper.nix index f8e5fc9ad1fd..4248f01ee800 100644 --- a/pkgs/applications/editors/neovim/wrapper.nix +++ b/pkgs/applications/editors/neovim/wrapper.nix @@ -23,7 +23,7 @@ let # certain plugins need a custom configuration (available in passthru.initLua) # to work with nix. # if true, the wrapper automatically appends those snippets when necessary - , autoconfigure ? false + , autoconfigure ? true # append to PATH runtime deps of plugins , autowrapRuntimeDeps ? false From 1d85984351e0c8952506a65cb276989c7248d120 Mon Sep 17 00:00:00 2001 From: "Matthieu C." <886074+teto@users.noreply.github.com> Date: Fri, 17 Jan 2025 23:03:55 +0100 Subject: [PATCH 2/3] neovim: enable autowrapRuntimeDeps by default like the autoconfigure setting, this represents a turning point in neovim plugins packaging and an additional way to avoid patching plugins. For instance in markdown-preview-nvim, instead of patching paths like: === super.markdown-preview-nvim.overrideAttrs { patches = [ (substituteAll { src = ./markdown-preview-nvim/fix-node-paths.patch; node = "${nodejs}/bin/node"; }) ]; postInstall = '' ln -s ${nodeDep}/node_modules $out/app ''; === we could add the program in PATH. You can still disable by using `neovim.overrideAttrs({ autowrapRuntimeDeps = false; })`. See the documentation at https://nixos.org/manual/nixpkgs/unstable/#neovim-custom-configuration. --- pkgs/applications/editors/neovim/wrapper.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/editors/neovim/wrapper.nix b/pkgs/applications/editors/neovim/wrapper.nix index 4248f01ee800..47795ac8954b 100644 --- a/pkgs/applications/editors/neovim/wrapper.nix +++ b/pkgs/applications/editors/neovim/wrapper.nix @@ -26,7 +26,7 @@ let , autoconfigure ? true # append to PATH runtime deps of plugins - , autowrapRuntimeDeps ? false + , autowrapRuntimeDeps ? true # should contain all args but the binary. Can be either a string or list , wrapperArgs ? [] From d0ec106920331dd9a083195d710eb424c7bfcd38 Mon Sep 17 00:00:00 2001 From: "Matthieu C." <886074+teto@users.noreply.github.com> Date: Wed, 15 Jan 2025 16:33:05 +0100 Subject: [PATCH 3/3] vimPlugins.typescript-tools-nvim: add runtimeDeps tsserver --- pkgs/applications/editors/vim/plugins/overrides.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/applications/editors/vim/plugins/overrides.nix b/pkgs/applications/editors/vim/plugins/overrides.nix index f856b3aa2f38..0fac70eb1665 100644 --- a/pkgs/applications/editors/vim/plugins/overrides.nix +++ b/pkgs/applications/editors/vim/plugins/overrides.nix @@ -57,6 +57,7 @@ tmux, tup, typescript, + typescript-language-server, vim, which, xdg-utils, @@ -3298,6 +3299,9 @@ in nvim-lspconfig plenary-nvim ]; + runtimeDeps = [ + typescript-language-server + ]; }; nvzone-typr = super.nvzone-typr.overrideAttrs {