From 78d4dc263993aa683d9b056f7785bfb3d5c1f7b0 Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Tue, 21 Jun 2022 09:10:52 -0500 Subject: [PATCH 1/3] duckdb: 0.3.4 -> 0.4.0 --- pkgs/development/libraries/duckdb/default.nix | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/pkgs/development/libraries/duckdb/default.nix b/pkgs/development/libraries/duckdb/default.nix index b128ed709452..cd70bd2bdeea 100644 --- a/pkgs/development/libraries/duckdb/default.nix +++ b/pkgs/development/libraries/duckdb/default.nix @@ -1,6 +1,7 @@ { lib , stdenv , fetchFromGitHub +, fetchpatch , cmake , ninja , openssl @@ -16,16 +17,23 @@ let in stdenv.mkDerivation rec { pname = "duckdb"; - version = "0.3.4"; + version = "0.4.0"; src = fetchFromGitHub { owner = pname; repo = pname; rev = "v${version}"; - sha256 = "sha256-2PBc5qe2md87u2nvMTx/XZVzLsr8QrvUkw46/6VTlGs="; + sha256 = "sha256-pQ/t26dv9ZWLl0MHcAn0sgxryW2T2hM8XyOkXyfC5CY="; }; - patches = [ ./version.patch ]; + patches = [ + ./version.patch + (fetchpatch { + url = "https://patch-diff.githubusercontent.com/raw/duckdb/duckdb/pull/3927.patch"; + sha256 = "sha256-m0Bs0DOJQtkadbKZKk88NHyBFJkjxXUsiWYciuRIJLU="; + }) + ]; + postPatch = '' substituteInPlace CMakeLists.txt --subst-var-by DUCKDB_VERSION "v${version}" ''; @@ -62,6 +70,7 @@ stdenv.mkDerivation rec { "test/common/test_cast_hugeint.test" "test/sql/copy/csv/test_csv_remote.test" "test/sql/copy/parquet/test_parquet_remote.test" + "test/sql/copy/parquet/test_parquet_remote_foreign_files.test" ] ++ lib.optionals stdenv.isAarch64 [ "test/sql/aggregate/aggregates/test_kurtosis.test" "test/sql/aggregate/aggregates/test_skewness.test" From 16f1c3ea1ef5f757508bf333141bfa1ef0defdd3 Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Tue, 21 Jun 2022 10:14:55 -0500 Subject: [PATCH 2/3] python3Packages.duckdb: add checkInputs --- pkgs/development/python-modules/duckdb/default.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/development/python-modules/duckdb/default.nix b/pkgs/development/python-modules/duckdb/default.nix index 787a54f26769..dd7ad8737975 100644 --- a/pkgs/development/python-modules/duckdb/default.nix +++ b/pkgs/development/python-modules/duckdb/default.nix @@ -1,9 +1,11 @@ { lib , buildPythonPackage , duckdb +, google-cloud-storage , mypy , numpy , pandas +, psutil , pybind11 , setuptools-scm , pytestCheckHook @@ -29,7 +31,9 @@ buildPythonPackage rec { ]; checkInputs = [ + google-cloud-storage mypy + psutil pytestCheckHook ]; From a0d48a151571165567a2d45df82e9791d7d239de Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Tue, 21 Jun 2022 12:14:47 -0500 Subject: [PATCH 3/3] duckdb: use upstream patch and name patch derivation --- pkgs/development/libraries/duckdb/default.nix | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/development/libraries/duckdb/default.nix b/pkgs/development/libraries/duckdb/default.nix index cd70bd2bdeea..059c79bfcbb5 100644 --- a/pkgs/development/libraries/duckdb/default.nix +++ b/pkgs/development/libraries/duckdb/default.nix @@ -29,7 +29,8 @@ stdenv.mkDerivation rec { patches = [ ./version.patch (fetchpatch { - url = "https://patch-diff.githubusercontent.com/raw/duckdb/duckdb/pull/3927.patch"; + name = "fix-tpce-test.patch"; + url = "https://github.com/duckdb/duckdb/commit/82e13a4bb9f0683af6c52468af2fb903cce4286d.patch"; sha256 = "sha256-m0Bs0DOJQtkadbKZKk88NHyBFJkjxXUsiWYciuRIJLU="; }) ];