From 1841ad02a3a6ce601b39c1ad5a9a9fb8ca8c9be6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 6 Jun 2022 01:33:03 +0200 Subject: [PATCH 1/4] ArchiSteamFarm: fix shellcheck problems --- pkgs/applications/misc/ArchiSteamFarm/updater.sh | 7 +++---- pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh | 8 ++++---- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/pkgs/applications/misc/ArchiSteamFarm/updater.sh b/pkgs/applications/misc/ArchiSteamFarm/updater.sh index 3c361d702394..6735c293c67d 100755 --- a/pkgs/applications/misc/ArchiSteamFarm/updater.sh +++ b/pkgs/applications/misc/ArchiSteamFarm/updater.sh @@ -1,6 +1,6 @@ #!/usr/bin/env nix-shell #!nix-shell -I nixpkgs=../../../.. -i bash -p curl gnused jq common-updater-scripts nuget-to-nix -set -exo pipefail +set -euox pipefail cd "$(dirname "${BASH_SOURCE[0]}")" deps_file="$(realpath ./deps)" @@ -18,7 +18,7 @@ fi cd ../../../.. nixpkgs_path=$(pwd) -if [[ "$1" != "--deps-only" ]]; then +if [[ "${1:-}" != "--deps-only" ]]; then update-source-version ArchiSteamFarm "$new_version" fi store_src="$(nix-build -A ArchiSteamFarm.src --no-out-link)" @@ -36,12 +36,11 @@ for i in $platforms; do nix-shell -I nixpkgs="$nixpkgs_path" -p dotnet-sdk_6 --argstr system $i --run " mkdir ./nuget_pkgs-$i for project in ArchiSteamFarm/ArchiSteamFarm.csproj ArchiSteamFarm.Tests/ArchiSteamFarm.Tests.csproj; do - dotnet restore $project --packages ./nuget_pkgs-$i + dotnet restore \$project --packages ./nuget_pkgs-$i done; nuget-to-nix ./nuget_pkgs-$i > $deps_file-$i.nix" \ || echo "Did you set up binformat for $i?"; - done; trap ' diff --git a/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh b/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh index dfe394c78586..b6e72bf19cbd 100755 --- a/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh +++ b/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh @@ -2,16 +2,16 @@ #! nix-shell -i bash -p nodePackages.node2nix gnused jq curl version=$(nix-instantiate --strict --eval -A ArchiSteamFarm.version | jq -r) -ui=$(curl ${GITHUB_TOKEN:+" -u \":$GITHUB_TOKEN\""} https://api.github.com/repos/JustArchiNET/ArchiSteamFarm/contents/ASF-ui?ref=${version} | jq -r .sha) +ui=$(curl ${GITHUB_TOKEN:+" -u \":$GITHUB_TOKEN\""} "https://api.github.com/repos/JustArchiNET/ArchiSteamFarm/contents/ASF-ui?ref=$version" | jq -r .sha) pushd $(dirname "$0") -curl https://raw.githubusercontent.com/JustArchiNET/ASF-ui/${ui}/package-lock.json -o package-lock.json -curl https://raw.githubusercontent.com/JustArchiNET/ASF-ui/${ui}/package.json -o package.json +curl "https://raw.githubusercontent.com/JustArchiNET/ASF-ui/$ui/package-lock.json" -o package-lock.json +curl "https://raw.githubusercontent.com/JustArchiNET/ASF-ui/$ui/package.json" -o package.json # update-source-version doesn't work for some reason sed -i "s/rev\\s*=\\s*.*/rev = \"$ui\";/" default.nix -sed -i "s/sha256\\s*=\\s*.*/sha256 = \"$(nix-prefetch-url --unpack https://github.com/JustArchiNET/ASF-ui/archive/$ui.tar.gz)\";/" default.nix +sed -i "s/sha256\\s*=\\s*.*/sha256 = \"$(nix-prefetch-url --unpack "https://github.com/JustArchiNET/ASF-ui/archive/$ui.tar.gz")\";/" default.nix node2nix \ --nodejs-14 \ From 89d5ef1295b0b78d23856741ac914f8868550173 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 6 Jun 2022 02:12:53 +0200 Subject: [PATCH 2/4] ArchiSteamFarm: update programm and web-ui in one run --- pkgs/applications/misc/ArchiSteamFarm/updater.sh | 3 +++ pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh | 8 +++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/misc/ArchiSteamFarm/updater.sh b/pkgs/applications/misc/ArchiSteamFarm/updater.sh index 6735c293c67d..9baedde025da 100755 --- a/pkgs/applications/misc/ArchiSteamFarm/updater.sh +++ b/pkgs/applications/misc/ArchiSteamFarm/updater.sh @@ -15,6 +15,7 @@ if [[ "$new_version" == "$old_version" ]]; then fi fi +asf_path=$(pwd) cd ../../../.. nixpkgs_path=$(pwd) @@ -47,3 +48,5 @@ trap ' popd rm -r "$src" ' EXIT +cd "$asf_path" +./web-ui/update.sh diff --git a/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh b/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh index b6e72bf19cbd..90f8baf8e1b6 100755 --- a/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh +++ b/pkgs/applications/misc/ArchiSteamFarm/web-ui/update.sh @@ -1,11 +1,13 @@ #!/usr/bin/env nix-shell -#! nix-shell -i bash -p nodePackages.node2nix gnused jq curl +#! nix-shell -I nixpkgs=../../../.. -i bash -p nodePackages.node2nix gnused jq curl +set -eoux pipefail +pushd ../../../.. version=$(nix-instantiate --strict --eval -A ArchiSteamFarm.version | jq -r) +popd +pushd "$(dirname "$0")" ui=$(curl ${GITHUB_TOKEN:+" -u \":$GITHUB_TOKEN\""} "https://api.github.com/repos/JustArchiNET/ArchiSteamFarm/contents/ASF-ui?ref=$version" | jq -r .sha) -pushd $(dirname "$0") - curl "https://raw.githubusercontent.com/JustArchiNET/ASF-ui/$ui/package-lock.json" -o package-lock.json curl "https://raw.githubusercontent.com/JustArchiNET/ASF-ui/$ui/package.json" -o package.json From 70a7d055f5c3e9bc5569e70fffb48a2d78d0a55d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 6 Jun 2022 02:13:29 +0200 Subject: [PATCH 3/4] ArchiSteamFarm: fix tmp filling up --- pkgs/applications/misc/ArchiSteamFarm/updater.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/misc/ArchiSteamFarm/updater.sh b/pkgs/applications/misc/ArchiSteamFarm/updater.sh index 9baedde025da..4ff04432040b 100755 --- a/pkgs/applications/misc/ArchiSteamFarm/updater.sh +++ b/pkgs/applications/misc/ArchiSteamFarm/updater.sh @@ -25,6 +25,11 @@ fi store_src="$(nix-build -A ArchiSteamFarm.src --no-out-link)" platforms="$(nix-instantiate --strict --eval --json -A ArchiSteamFarm.meta.platforms | jq -r .[])" src="$(mktemp -d /tmp/ArchiSteamFarm-src.XXX)" + +trap ' + rm -r "$src" +' EXIT + cp -rT "$store_src" "$src" chmod -R +w "$src" @@ -44,9 +49,5 @@ for i in $platforms; do || echo "Did you set up binformat for $i?"; done; -trap ' - popd - rm -r "$src" -' EXIT cd "$asf_path" ./web-ui/update.sh From 1235314d6cc0a239eb15061f8c3a9e28b11dbf39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 6 Jun 2022 02:13:56 +0200 Subject: [PATCH 4/4] ArchiSteamFarm: normalize file names --- pkgs/applications/misc/ArchiSteamFarm/default.nix | 2 +- pkgs/applications/misc/ArchiSteamFarm/{updater.sh => update.sh} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename pkgs/applications/misc/ArchiSteamFarm/{updater.sh => update.sh} (100%) diff --git a/pkgs/applications/misc/ArchiSteamFarm/default.nix b/pkgs/applications/misc/ArchiSteamFarm/default.nix index 4c0e1d6b7305..d9da9e34b737 100644 --- a/pkgs/applications/misc/ArchiSteamFarm/default.nix +++ b/pkgs/applications/misc/ArchiSteamFarm/default.nix @@ -41,7 +41,7 @@ buildDotnetModule rec { ''; passthru = { - updateScript = ./updater.sh; + updateScript = ./update.sh; ui = callPackage ./web-ui { }; }; diff --git a/pkgs/applications/misc/ArchiSteamFarm/updater.sh b/pkgs/applications/misc/ArchiSteamFarm/update.sh similarity index 100% rename from pkgs/applications/misc/ArchiSteamFarm/updater.sh rename to pkgs/applications/misc/ArchiSteamFarm/update.sh