From 8024ef9b1cdc7d58f5f5939d14a758989f682164 Mon Sep 17 00:00:00 2001 From: Aidan Gauland Date: Tue, 12 Sep 2023 08:48:00 +1200 Subject: [PATCH] nushellPlugins: fix check phases --- pkgs/shells/nushell/plugins/formats.nix | 4 +++- pkgs/shells/nushell/plugins/gstat.nix | 4 +++- pkgs/shells/nushell/plugins/query.nix | 5 +++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/pkgs/shells/nushell/plugins/formats.nix b/pkgs/shells/nushell/plugins/formats.nix index dac2e4b14381..710ecf92bf08 100644 --- a/pkgs/shells/nushell/plugins/formats.nix +++ b/pkgs/shells/nushell/plugins/formats.nix @@ -15,7 +15,9 @@ rustPlatform.buildRustPackage { nativeBuildInputs = [ pkg-config ]; buildInputs = lib.optionals stdenv.isDarwin [ IOKit Foundation ]; cargoBuildFlags = [ "--package nu_plugin_formats" ]; - doCheck = false; + checkPhase = '' + cargo test --manifest-path crates/nu_plugin_formats/Cargo.toml + ''; meta = with lib; { description = "A formats plugin for Nushell"; homepage = "https://github.com/nushell/nushell/tree/main/crates/nu_plugin_formats"; diff --git a/pkgs/shells/nushell/plugins/gstat.nix b/pkgs/shells/nushell/plugins/gstat.nix index 91730af6596b..ba974ad2443c 100644 --- a/pkgs/shells/nushell/plugins/gstat.nix +++ b/pkgs/shells/nushell/plugins/gstat.nix @@ -15,7 +15,9 @@ rustPlatform.buildRustPackage { nativeBuildInputs = [ pkg-config ]; buildInputs = [ openssl ] ++ lib.optionals stdenv.isDarwin [ Security ]; cargoBuildFlags = [ "--package nu_plugin_gstat" ]; - doCheck = false; # some tests fail + checkPhase = '' + cargo test --manifest-path crates/nu_plugin_gstat/Cargo.toml + ''; meta = with lib; { description = "A git status plugin for Nushell"; homepage = "https://github.com/nushell/nushell/tree/main/crates/nu_plugin_gstat"; diff --git a/pkgs/shells/nushell/plugins/query.nix b/pkgs/shells/nushell/plugins/query.nix index feaeb7f63d11..d13170d275ad 100644 --- a/pkgs/shells/nushell/plugins/query.nix +++ b/pkgs/shells/nushell/plugins/query.nix @@ -19,8 +19,9 @@ rustPlatform.buildRustPackage { cargoBuildFlags = [ "--package nu_plugin_query" ]; - # compilation fails with a missing symbol - doCheck = false; + checkPhase = '' + cargo test --manifest-path crates/nu_plugin_query/Cargo.toml + ''; passthru = { updateScript = nix-update-script { };