From 51cd84ba57e5acde737d71919b1728fb309b1296 Mon Sep 17 00:00:00 2001 From: Peder Bergebakken Sundt Date: Mon, 29 Apr 2024 01:41:45 +0200 Subject: [PATCH] pkgs/README.md: add `meta.mainProgram` to new-package checklist template The document already states that `meta.mainProgram` is mandatory for new packages, this change adds it to the template list of checks during review. --- pkgs/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/README.md b/pkgs/README.md index 5439ad913d18..fd958702fb49 100644 --- a/pkgs/README.md +++ b/pkgs/README.md @@ -748,6 +748,7 @@ Review process: - License must match the upstream license. - Platforms should be set (or the package will not get binary substitutes). - Maintainers must be set. This can be the package submitter or a community member that accepts taking up maintainership of the package. + - The `meta.mainProgram` must be set if a main executable exists. - Report detected typos. - Ensure the package source: - Uses `mirror://` URLs when available. @@ -769,6 +770,7 @@ Sample template for a new package review is provided below. - [ ] `meta.license` fits upstream license - [ ] `meta.platforms` is set - [ ] `meta.maintainers` is set +- [ ] `meta.mainProgram` is set, if applicable. - [ ] build time only dependencies are declared in `nativeBuildInputs` - [ ] source is fetched using the appropriate function - [ ] the list of `phases` is not overridden