From 7a8407e477f5892104f9ccd00972e18245be8a82 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= <joerg@thalheim.io>
Date: Thu, 14 Nov 2024 00:23:00 +0100
Subject: [PATCH] nixos-option: fix potential memory leak in mapOptions

---
 pkgs/tools/nix/nixos-option/.clang-tidy         | 1 -
 pkgs/tools/nix/nixos-option/src/nixos-option.cc | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/pkgs/tools/nix/nixos-option/.clang-tidy b/pkgs/tools/nix/nixos-option/.clang-tidy
index 1d92756771f3..4627a18c7161 100644
--- a/pkgs/tools/nix/nixos-option/.clang-tidy
+++ b/pkgs/tools/nix/nixos-option/.clang-tidy
@@ -1,5 +1,4 @@
 Checks:
-- -*
 - bugprone-*
 # don't find them too problematic
 - -bugprone-easily-swappable-parameters
diff --git a/pkgs/tools/nix/nixos-option/src/nixos-option.cc b/pkgs/tools/nix/nixos-option/src/nixos-option.cc
index 6846cc7e5fbb..99997afb17c1 100644
--- a/pkgs/tools/nix/nixos-option/src/nixos-option.cc
+++ b/pkgs/tools/nix/nixos-option/src/nixos-option.cc
@@ -313,7 +313,7 @@ void mapOptions(const std::function<void(const std::string & path)> & f, Context
 {
     auto root = findAlongOptionPath(ctx, path);
     recurse(
-        [f, &ctx](const std::string & path, std::variant<Value, std::exception_ptr> v) {
+        [&f, &ctx](const std::string & path, std::variant<Value, std::exception_ptr> v) {
             const bool isOpt = std::holds_alternative<std::exception_ptr>(v) || isOption(ctx, std::get<Value>(v));
             if (isOpt) {
                 f(path);