From ca6bb4761f248949c9e9d1c7d5d53168fc90f508 Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Thu, 6 Nov 2025 12:59:14 +0530 Subject: [PATCH 1/3] tidy-viewer: add phanirithvij as maintainer Signed-off-by: phanirithvij --- pkgs/by-name/ti/tidy-viewer/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/ti/tidy-viewer/package.nix b/pkgs/by-name/ti/tidy-viewer/package.nix index 44d7f7e4aba2..3175210a15f3 100644 --- a/pkgs/by-name/ti/tidy-viewer/package.nix +++ b/pkgs/by-name/ti/tidy-viewer/package.nix @@ -29,6 +29,6 @@ rustPlatform.buildRustPackage rec { homepage = "https://github.com/alexhallam/tv"; changelog = "https://github.com/alexhallam/tv/blob/${version}/CHANGELOG.md"; license = lib.licenses.unlicense; - maintainers = [ ]; + maintainers = with lib.maintainers; [ phanirithvij ]; }; } From a9fe3a48ca6fade79c30970e77e2028b1765525a Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Thu, 6 Nov 2025 13:00:02 +0530 Subject: [PATCH 2/3] tidy-viewer: refactor to use finalAttrs Signed-off-by: phanirithvij --- pkgs/by-name/ti/tidy-viewer/package.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/ti/tidy-viewer/package.nix b/pkgs/by-name/ti/tidy-viewer/package.nix index 3175210a15f3..653159bf8d12 100644 --- a/pkgs/by-name/ti/tidy-viewer/package.nix +++ b/pkgs/by-name/ti/tidy-viewer/package.nix @@ -4,14 +4,14 @@ fetchFromGitHub, }: -rustPlatform.buildRustPackage rec { +rustPlatform.buildRustPackage (finalAttrs: { pname = "tidy-viewer"; version = "1.8.93"; src = fetchFromGitHub { owner = "alexhallam"; repo = "tv"; - rev = version; + tag = finalAttrs.version; sha256 = "sha256-wiVcdTnjEFh5kSyxmK+ab0LkEAbQaygmLdrFfM12DyM="; }; @@ -24,11 +24,11 @@ rustPlatform.buildRustPackage rec { ]; meta = { + changelog = "https://github.com/alexhallam/tv/blob/${finalAttrs.version}/CHANGELOG.md"; description = "Cross-platform CLI csv pretty printer that uses column styling to maximize viewer enjoyment"; - mainProgram = "tidy-viewer"; homepage = "https://github.com/alexhallam/tv"; - changelog = "https://github.com/alexhallam/tv/blob/${version}/CHANGELOG.md"; license = lib.licenses.unlicense; + mainProgram = "tidy-viewer"; maintainers = with lib.maintainers; [ phanirithvij ]; }; -} +}) From 719cee4d9d1e7a2cb82dc996e1dc3b09b16580c5 Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Thu, 6 Nov 2025 13:00:37 +0530 Subject: [PATCH 3/3] tidy-viewer: enable skipped test seems to work fine on x86_64-linux Signed-off-by: phanirithvij --- pkgs/by-name/ti/tidy-viewer/package.nix | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkgs/by-name/ti/tidy-viewer/package.nix b/pkgs/by-name/ti/tidy-viewer/package.nix index 653159bf8d12..c6e26ee7606a 100644 --- a/pkgs/by-name/ti/tidy-viewer/package.nix +++ b/pkgs/by-name/ti/tidy-viewer/package.nix @@ -17,12 +17,6 @@ rustPlatform.buildRustPackage (finalAttrs: { cargoHash = "sha256-HF7M4s2OHCAyVkbCIBxGButAxbxrhjmY3YE/do8et1s="; - # this test parses command line arguments - # error: Found argument '--test-threads' which wasn't expected, or isn't valid in this context - checkFlags = [ - "--skip=build_reader_can_create_reader_without_file_specified" - ]; - meta = { changelog = "https://github.com/alexhallam/tv/blob/${finalAttrs.version}/CHANGELOG.md"; description = "Cross-platform CLI csv pretty printer that uses column styling to maximize viewer enjoyment";