From 40963bf4c2ba701cd09a3b1caa333b7b32e91494 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Mon, 5 May 2025 21:49:52 +0200 Subject: [PATCH] workflows/no-channel: run again when base changed Because of the branches filter, the job would **not** re-run when only the base-branch was changed, thus leaving the contributor with a failed check. With this change, the job should be triggered and then skipped in this case, so the check in the list should be replaced with a skip. Note, this also means that this step will show up in every PR as skipped, even when it was never failed before. --- .github/workflows/no-channel.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/no-channel.yml b/.github/workflows/no-channel.yml index acaa937ad936..8a0d78114613 100644 --- a/.github/workflows/no-channel.yml +++ b/.github/workflows/no-channel.yml @@ -4,14 +4,14 @@ on: pull_request_target: # Re-run should be triggered when the base branch is updated, instead of silently failing types: [opened, synchronize, reopened, edited] - branches: - - 'nixos-**' - - 'nixpkgs-**' permissions: {} jobs: fail: + if: | + startsWith(github.event.pull_request.base.ref, 'nixos-') || + startsWith(github.event.pull_request.base.ref, 'nixpkgs-') name: "This PR is is targeting a channel branch" runs-on: ubuntu-24.04 steps: