From 79bff9e876fc04840882c1c8955a07bd643a6f7a Mon Sep 17 00:00:00 2001 From: Sirio Balmelli Date: Thu, 11 Jul 2024 09:54:49 +0200 Subject: [PATCH] rocksdb: fix broken build Correctly mark liburing dependency as linux-specific, fixes all builds on Darwin. Don't apply liburing patches before v6.29.3, fixes rocksdb_6_23 Signed-off-by: Sirio Balmelli Co-authored-by: Austin Horstman Co-authored-by: Pavol Rusnak --- pkgs/development/libraries/rocksdb/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/libraries/rocksdb/default.nix b/pkgs/development/libraries/rocksdb/default.nix index 2c70046108da..14e4e29e0c6e 100644 --- a/pkgs/development/libraries/rocksdb/default.nix +++ b/pkgs/development/libraries/rocksdb/default.nix @@ -11,7 +11,7 @@ , windows , enableJemalloc ? false , jemalloc -, enableLiburing ? true +, enableLiburing ? stdenv.isLinux , liburing , enableShared ? !stdenv.hostPlatform.isStatic , sse42Support ? stdenv.hostPlatform.sse4_2Support @@ -28,7 +28,7 @@ stdenv.mkDerivation (finalAttrs: { hash = "sha256-bTUzh7ch14TDcm6GkfhA5I/qUVmUm+RE5d2HMZ3zaNc="; }; - patches = [ ./fix-findliburing.patch ]; + patches = lib.optional (lib.versionAtLeast finalAttrs.version "6.29.3" && enableLiburing) ./fix-findliburing.patch; nativeBuildInputs = [ cmake ninja ];