diff --git a/pkgs/development/libraries/composable_kernel/default.nix b/pkgs/development/libraries/composable_kernel/default.nix index 58966d9140f3..c5653be28942 100644 --- a/pkgs/development/libraries/composable_kernel/default.nix +++ b/pkgs/development/libraries/composable_kernel/default.nix @@ -11,11 +11,6 @@ , gpuTargets ? [ ] # gpuTargets = [ "gfx803" "gfx900" "gfx1030" ... ] }: -# Several tests seem to either not compile or have a race condition -# Undefined reference to symbol '_ZTIN7testing4TestE' -# Try removing this next update -assert buildTests == false; - stdenv.mkDerivation (finalAttrs: { pname = "composable_kernel"; version = "unstable-2022-11-19"; @@ -87,5 +82,9 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/composable_kernel"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; + # Several tests seem to either not compile or have a race condition + # Undefined reference to symbol '_ZTIN7testing4TestE' + # Try removing this next update + broken = buildTests; }; }) diff --git a/pkgs/development/libraries/rocblas/default.nix b/pkgs/development/libraries/rocblas/default.nix index fb67bf779e85..6151ecd8d914 100644 --- a/pkgs/development/libraries/rocblas/default.nix +++ b/pkgs/development/libraries/rocblas/default.nix @@ -28,11 +28,6 @@ , gpuTargets ? [ "all" ] }: -# Tests and benchmarks are a can of worms that I will tackle in a different PR -# It involves completely rewriting the amd-blis derivation -assert buildTests == false; -assert buildBenchmarks == false; - stdenv.mkDerivation (finalAttrs: { pname = "rocblas"; repoVersion = "2.45.0"; @@ -135,6 +130,8 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocBLAS"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + # Tests and benchmarks are a can of worms that I will tackle in a different PR + # It involves completely rewriting the amd-blis derivation + broken = finalAttrs.rocmVersion != hip.version || buildTests || buildBenchmarks; }; }) diff --git a/pkgs/development/libraries/rocthrust/default.nix b/pkgs/development/libraries/rocthrust/default.nix index 2a59a72d9659..b5865fc8bc1c 100644 --- a/pkgs/development/libraries/rocthrust/default.nix +++ b/pkgs/development/libraries/rocthrust/default.nix @@ -14,11 +14,6 @@ , buildBenchmarks ? false }: -# Doesn't seem to work, thousands of errors compiling with no clear fix -# Is this an upstream issue? We don't seem to be missing dependencies -assert buildTests == false; -assert buildBenchmarks == false; - stdenv.mkDerivation (finalAttrs: { pname = "rocthrust"; repoVersion = "2.16.0"; @@ -96,6 +91,8 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocThrust"; license = with licenses; [ asl20 ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + # Tests/Benchmarks don't seem to work, thousands of errors compiling with no clear fix + # Is this an upstream issue? We don't seem to be missing dependencies + broken = finalAttrs.rocmVersion != hip.version || buildTests || buildBenchmarks; }; }) diff --git a/pkgs/development/libraries/rocwmma/default.nix b/pkgs/development/libraries/rocwmma/default.nix index d34e8752da8c..49746f83cd83 100644 --- a/pkgs/development/libraries/rocwmma/default.nix +++ b/pkgs/development/libraries/rocwmma/default.nix @@ -18,10 +18,6 @@ , gpuTargets ? [ ] # gpuTargets = [ "gfx908:xnack-" "gfx90a:xnack-" "gfx90a:xnack+" ... ] }: -# Building tests isn't working for now -# undefined reference to symbol '_ZTIN7testing4TestE' -assert buildTests == false; - let latex = lib.optionalAttrs buildDocs texlive.combine { inherit (texlive) scheme-small @@ -142,6 +138,8 @@ in stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocWMMA"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + # Building tests isn't working for now + # undefined reference to symbol '_ZTIN7testing4TestE' + broken = finalAttrs.rocmVersion != hip.version || buildTests; }; })