From 78a40d3403a0ea32b3a98656371fde6d1127973b Mon Sep 17 00:00:00 2001
From: Dominique Martinet <asmadeus@codewreck.org>
Date: Sun, 21 Jul 2024 21:26:57 +0900
Subject: [PATCH] bcc: fix bashreadline

- we didn't provide the newly required elfutils python dependency,
but we're only dealing with newer bashes so just use the new symbol
- while here also default to using our libreadline as bash is configured
to use it on nixos; this can still be overriden

Link: https://github.com/iovisor/bcc/pull/4903
Fixes: #328743
---
 ...ine.py-remove-dependency-on-elftools.patch | 48 +++++++++++++++++++
 pkgs/by-name/bc/bcc/package.nix               |  9 +++-
 2 files changed, 56 insertions(+), 1 deletion(-)
 create mode 100644 pkgs/by-name/bc/bcc/bashreadline.py-remove-dependency-on-elftools.patch

diff --git a/pkgs/by-name/bc/bcc/bashreadline.py-remove-dependency-on-elftools.patch b/pkgs/by-name/bc/bcc/bashreadline.py-remove-dependency-on-elftools.patch
new file mode 100644
index 000000000000..dfc3d3c9d2bb
--- /dev/null
+++ b/pkgs/by-name/bc/bcc/bashreadline.py-remove-dependency-on-elftools.patch
@@ -0,0 +1,48 @@
+From 25c77bff079c331ae12d9e4499c82fdabf301610 Mon Sep 17 00:00:00 2001
+From: Dominique Martinet <asmadeus@codewreck.org>
+Date: Sun, 21 Jul 2024 20:59:51 +0900
+Subject: [PATCH] bashreadline.py: remove dependency on elftools
+
+This helper is only here to differentiate between very old bash
+versions or semi-recent ones; since we'll only catter to newer
+bash versions we don't need to bother with elftools here:
+just hardcode the newer symbol.
+---
+ tools/bashreadline.py | 14 +-------------
+ 1 file changed, 1 insertion(+), 13 deletions(-)
+
+diff --git a/tools/bashreadline.py b/tools/bashreadline.py
+index 7e8324a2c0ea..e4b20aeb2371 100755
+--- a/tools/bashreadline.py
++++ b/tools/bashreadline.py
+@@ -17,7 +17,6 @@
+ # 12-Feb-2016    Allan McAleavy migrated to BPF_PERF_OUTPUT
+ 
+ from __future__ import print_function
+-from elftools.elf.elffile import ELFFile
+ from bcc import BPF
+ from time import strftime
+ import argparse
+@@ -33,18 +32,7 @@ args = parser.parse_args()
+ 
+ name = args.shared if args.shared else "/bin/bash"
+ 
+-
+-def get_sym(filename):
+-    with open(filename, 'rb') as f:
+-        elf = ELFFile(f)
+-        symbol_table = elf.get_section_by_name(".dynsym")
+-        for symbol in symbol_table.iter_symbols():
+-            if symbol.name == "readline_internal_teardown":
+-                return "readline_internal_teardown"
+-    return "readline"
+-
+-
+-sym = get_sym(name)
++sym = "readline_internal_teardown"
+ 
+ # load BPF program
+ bpf_text = """
+-- 
+2.45.2
+
diff --git a/pkgs/by-name/bc/bcc/package.nix b/pkgs/by-name/bc/bcc/package.nix
index c077661abcba..e8404b9fb624 100644
--- a/pkgs/by-name/bc/bcc/package.nix
+++ b/pkgs/by-name/bc/bcc/package.nix
@@ -15,6 +15,7 @@
   netperf,
   nixosTests,
   python3Packages,
+  readline,
   stdenv,
   zip,
 }:
@@ -50,6 +51,9 @@ python3Packages.buildPythonApplication rec {
     # This is needed until we fix
     # https://github.com/NixOS/nixpkgs/issues/40427
     ./fix-deadlock-detector-import.patch
+    # Quick & dirty fix for bashreadline
+    # https://github.com/NixOS/nixpkgs/issues/328743
+    ./bashreadline.py-remove-dependency-on-elftools.patch
   ];
 
   propagatedBuildInputs = [ python3Packages.netaddr ];
@@ -85,7 +89,10 @@ python3Packages.buildPythonApplication rec {
 
     # https://github.com/iovisor/bcc/issues/3996
     substituteInPlace src/cc/libbcc.pc.in \
-      --replace '$'{exec_prefix}/@CMAKE_INSTALL_LIBDIR@ @CMAKE_INSTALL_FULL_LIBDIR@
+      --replace-fail '$'{exec_prefix}/@CMAKE_INSTALL_LIBDIR@ @CMAKE_INSTALL_FULL_LIBDIR@
+
+    substituteInPlace tools/bashreadline.py \
+      --replace-fail '/bin/bash' '${readline}/lib/libreadline.so'
   '';
 
   preInstall = ''