From bb6c08c8d5d9a04fecf18d7a000d99ec96567cc2 Mon Sep 17 00:00:00 2001 From: Nick Cao Date: Sat, 1 Oct 2022 17:44:33 +0800 Subject: [PATCH 1/2] flac: build with cmake, fixes cross compilation --- pkgs/applications/audio/flac/default.nix | 27 +++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/audio/flac/default.nix b/pkgs/applications/audio/flac/default.nix index c9e3b946dd19..644a19c0f040 100644 --- a/pkgs/applications/audio/flac/default.nix +++ b/pkgs/applications/audio/flac/default.nix @@ -1,4 +1,12 @@ -{ lib, stdenv, fetchurl, fetchpatch, libogg }: +{ lib +, stdenv +, fetchurl +, cmake +, pkg-config +, doxygen +, graphviz +, libogg +}: stdenv.mkDerivation rec { pname = "flac"; @@ -10,9 +18,22 @@ stdenv.mkDerivation rec { sha256 = "91303c3e5dfde52c3e94e75976c0ab3ee14ced278ab8f60033a3a12db9209ae6"; }; - buildInputs = [ libogg ]; + nativeBuildInputs = [ + cmake + pkg-config + doxygen + graphviz + ]; - #doCheck = true; # takes lots of time + buildInputs = [ + libogg + ]; + + cmakeFlags = lib.optionals (!stdenv.hostPlatform.isStatic) [ + "-DBUILD_SHARED_LIBS=ON" + ]; + + # doCheck = true; # takes lots of time outputs = [ "bin" "dev" "out" "man" "doc" ]; From b8a03cec225e78bb112c66836fc85720801cb377 Mon Sep 17 00:00:00 2001 From: Nick Cao Date: Mon, 3 Oct 2022 09:57:35 +0800 Subject: [PATCH 2/2] flac: set CFLAGS and CXXFLAGS to match performance of autotools build --- pkgs/applications/audio/flac/default.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/applications/audio/flac/default.nix b/pkgs/applications/audio/flac/default.nix index 644a19c0f040..bebb35f45009 100644 --- a/pkgs/applications/audio/flac/default.nix +++ b/pkgs/applications/audio/flac/default.nix @@ -33,6 +33,9 @@ stdenv.mkDerivation rec { "-DBUILD_SHARED_LIBS=ON" ]; + CFLAGS = [ "-O3" "-funroll-loops" ]; + CXXFLAGS = [ "-O3" ]; + # doCheck = true; # takes lots of time outputs = [ "bin" "dev" "out" "man" "doc" ];