From 71e704768dc14dfd9dece3e2f4ee9cdb7caebda6 Mon Sep 17 00:00:00 2001
From: Silvan Mosberger <silvan.mosberger@moduscreate.com>
Date: Sat, 7 Feb 2026 13:50:46 +0100
Subject: [PATCH] ci/github-script/reviewers.js: Fix reviewer API request

It takes arrays, not sets, see https://github.com/NixOS/nixpkgs/actions/runs/21735690914/job/62700395870?pr=487491
---
 ci/github-script/reviewers.js | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/ci/github-script/reviewers.js b/ci/github-script/reviewers.js
index fbbcc996eba9..be458ba4eb32 100644
--- a/ci/github-script/reviewers.js
+++ b/ci/github-script/reviewers.js
@@ -139,26 +139,27 @@ async function handleReviewers({
   }
 
   // We don't want to rerequest reviews from people who already reviewed or were requested
-  const users_not_yet_reached = users_to_reach.difference(users_reached)
-  log(
-    'reviewers - users_not_yet_reached',
-    Array.from(users_not_yet_reached).join(', '),
+  const users_not_yet_reached = Array.from(
+    users_to_reach.difference(users_reached),
   )
+  log('reviewers - users_not_yet_reached', users_not_yet_reached.join(', '))
   // We don't want to rerequest reviews from teams who already reviewed or were requested
-  const teams_not_yet_reached = teams_to_reach.difference(teams_reached)
-  log(
-    'reviewers - teams_not_yet_reached',
-    Array.from(teams_not_yet_reached).join(', '),
+  const teams_not_yet_reached = Array.from(
+    teams_to_reach.difference(teams_reached),
   )
+  log('reviewers - teams_not_yet_reached', teams_not_yet_reached.join(', '))
 
-  if (users_not_yet_reached.size === 0 && teams_not_yet_reached.size === 0) {
+  if (
+    users_not_yet_reached.length === 0 &&
+    teams_not_yet_reached.length === 0
+  ) {
     log('Has reviewer changes', 'false (skipped)')
   } else if (dry) {
     core.info(
-      `Requesting user reviewers for #${pull_number}: ${Array.from(users_not_yet_reached).join(', ')} (dry)`,
+      `Requesting user reviewers for #${pull_number}: ${users_not_yet_reached.join(', ')} (dry)`,
     )
     core.info(
-      `Requesting team reviewers for #${pull_number}: ${Array.from(teams_not_yet_reached).join(', ')} (dry)`,
+      `Requesting team reviewers for #${pull_number}: ${teams_not_yet_reached.join(', ')} (dry)`,
     )
   } else {
     // We had tried the "request all reviewers at once" thing in the past, but it didn't work out:
@@ -175,8 +176,8 @@ async function handleReviewers({
 
   // Return a boolean on whether the "needs: reviewers" label should be set.
   return (
-    users_not_yet_reached.size === 0 &&
-    teams_not_yet_reached.size === 0 &&
+    users_not_yet_reached.length === 0 &&
+    teams_not_yet_reached.length === 0 &&
     users_reached.size === 0 &&
     teams_reached.size === 0
   )