From 70c0f1059c44f4ddfdded8764adcf462785e75f7 Mon Sep 17 00:00:00 2001
From: Aliaksandr <grubian2@gmail.com>
Date: Tue, 23 Jun 2026 22:19:22 +0300
Subject: [PATCH] nixos/glusterfs: install group presets into /var/lib/glusterd

Upstream installs the volume option presets into
$(localstatedir)/lib/glusterd/groups, which ends up under the package's
$out/var rather than /var, so `gluster volume set <vol> group <name>`
failed for metadata-cache, nl-cache, virt, etc. Copy them into place
alongside the existing hooks rehydration.

Fixes #33159.

Assisted-by: claude-code with claude-opus-4-8[1m]-high
---
 nixos/modules/services/network-filesystems/glusterfs.nix | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/nixos/modules/services/network-filesystems/glusterfs.nix b/nixos/modules/services/network-filesystems/glusterfs.nix
index ad909321d293..c218d5505566 100644
--- a/nixos/modules/services/network-filesystems/glusterfs.nix
+++ b/nixos/modules/services/network-filesystems/glusterfs.nix
@@ -191,6 +191,12 @@ in
       + ''
         mkdir -p /var/lib/glusterd/glusterfind/.keys
         mkdir -p /var/lib/glusterd/hooks/1/delete/post/
+      ''
+      # Volume option presets, installed by upstream under $out/var; copy them so
+      # `gluster volume set <vol> group <name>` works (#33159).
+      + ''
+        mkdir -p /var/lib/glusterd/groups/
+        ${rsync}/bin/rsync -a ${glusterfs}/var/lib/glusterd/groups/ /var/lib/glusterd/groups/
       '';
 
       serviceConfig = {