From 61feedfa7d3fb10491bbfac0f418eed46465ed31 Mon Sep 17 00:00:00 2001 From: Xiangyan Sun Date: Sun, 3 May 2026 12:56:42 -0700 Subject: [PATCH 1/2] ophcrack: fix build --- pkgs/by-name/op/ophcrack/package.nix | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pkgs/by-name/op/ophcrack/package.nix b/pkgs/by-name/op/ophcrack/package.nix index 9ae150020b8c..4a6c6b79ccd6 100644 --- a/pkgs/by-name/op/ophcrack/package.nix +++ b/pkgs/by-name/op/ophcrack/package.nix @@ -33,9 +33,9 @@ stdenv.mkDerivation (finalAttrs: { nativeBuildInputs = [ pkg-config ] ++ lib.optional enableGui libsForQt5.wrapQtAppsHook; buildInputs = [ openssl + expat ] - ++ (if enableGui then [ libsForQt5.qtcharts ] else [ expat ]) - ++ lib.optional stdenv.hostPlatform.isDarwin expat; + ++ lib.optional enableGui libsForQt5.qtcharts; configureFlags = [ "--with-libssl" @@ -50,11 +50,6 @@ stdenv.mkDerivation (finalAttrs: { [ "--disable-gui" ] ); - installPhase = lib.optional stdenv.hostPlatform.isDarwin '' - mkdir -p $out/bin - cp -R src/ophcrack $out/bin - ''; - meta = { description = "Free Windows password cracker based on rainbow tables"; homepage = "https://ophcrack.sourceforge.io"; From a689c61315d45ec7f7785503dd3a8e6602323741 Mon Sep 17 00:00:00 2001 From: Xiangyan Sun Date: Fri, 8 May 2026 09:41:10 -0700 Subject: [PATCH 2/2] ophcrack: fix darwin build --- pkgs/by-name/op/ophcrack/package.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/by-name/op/ophcrack/package.nix b/pkgs/by-name/op/ophcrack/package.nix index 4a6c6b79ccd6..31b341415cc0 100644 --- a/pkgs/by-name/op/ophcrack/package.nix +++ b/pkgs/by-name/op/ophcrack/package.nix @@ -50,6 +50,11 @@ stdenv.mkDerivation (finalAttrs: { [ "--disable-gui" ] ); + installPhase = lib.optional (stdenv.hostPlatform.isDarwin && enableGui) '' + mkdir -p $out/Applications + cp -R src/ophcrack.app $out/Applications/ophcrack.app + ''; + meta = { description = "Free Windows password cracker based on rainbow tables"; homepage = "https://ophcrack.sourceforge.io";