From b59b5bae807cdd638b4a92b26e2c85853afce1ef Mon Sep 17 00:00:00 2001 From: Luna Nova Date: Sat, 1 Nov 2025 11:02:43 -0700 Subject: [PATCH 1/2] python3Packages.torch: fix ROCm build by disabling USE_FBGEMM_GENAI --- pkgs/development/python-modules/torch/source/default.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/development/python-modules/torch/source/default.nix b/pkgs/development/python-modules/torch/source/default.nix index cae1d47971e9..660131cb53c5 100644 --- a/pkgs/development/python-modules/torch/source/default.nix +++ b/pkgs/development/python-modules/torch/source/default.nix @@ -521,6 +521,9 @@ buildPythonPackage.override { inherit stdenv; } rec { } // lib.optionalAttrs rocmSupport { AOTRITON_INSTALLED_PREFIX = "${rocmPackages.aotriton}"; + # Broken HIP flag setup, fails to compile due to not finding rocthrust + # Only supports gfx942 so let's turn it off for now + USE_FBGEMM_GENAI = setBool false; }; nativeBuildInputs = [ From 0610e52b10842a9a3359858449c3af86ac65a570 Mon Sep 17 00:00:00 2001 From: Luna Nova Date: Sat, 1 Nov 2025 11:58:55 -0700 Subject: [PATCH 2/2] python3Packages.torch: add LunNova to maintainers --- pkgs/development/python-modules/torch/source/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/development/python-modules/torch/source/default.nix b/pkgs/development/python-modules/torch/source/default.nix index 660131cb53c5..960a5c2a109d 100644 --- a/pkgs/development/python-modules/torch/source/default.nix +++ b/pkgs/development/python-modules/torch/source/default.nix @@ -763,6 +763,7 @@ buildPythonPackage.override { inherit stdenv; } rec { license = lib.licenses.bsd3; maintainers = with lib.maintainers; [ GaetanLepage + LunNova # esp. for ROCm teh thoughtpolice tscholak