From 56878d144961c7b169703de1af35b132d95a2295 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gutyina=20Gerg=C5=91?= Date: Thu, 7 Nov 2024 00:16:13 +0100 Subject: [PATCH 1/5] bruno: remove phantomjs --- pkgs/by-name/br/bruno/package.nix | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkgs/by-name/br/bruno/package.nix b/pkgs/by-name/br/bruno/package.nix index 72d8c643b40c..19c05ce4b4ac 100644 --- a/pkgs/by-name/br/bruno/package.nix +++ b/pkgs/by-name/br/bruno/package.nix @@ -5,7 +5,6 @@ buildNpmPackage, nix-update-script, electron, - writeShellScriptBin, makeWrapper, copyDesktopItems, makeDesktopItem, @@ -37,7 +36,6 @@ buildNpmPackage rec { nativeBuildInputs = [ - (writeShellScriptBin "phantomjs" "echo 2.1.1") pkg-config ] ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [ From f90a7c4dbd7e5769102a82cc85ba651553c5599d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gutyina=20Gerg=C5=91?= Date: Thu, 7 Nov 2024 00:20:32 +0100 Subject: [PATCH 2/5] bruno: 1.34.0 -> 1.34.2 --- pkgs/by-name/br/bruno/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/br/bruno/package.nix b/pkgs/by-name/br/bruno/package.nix index 19c05ce4b4ac..5f0e15fc5db4 100644 --- a/pkgs/by-name/br/bruno/package.nix +++ b/pkgs/by-name/br/bruno/package.nix @@ -18,20 +18,20 @@ buildNpmPackage rec { pname = "bruno"; - version = "1.34.0"; + version = "1.34.2"; src = fetchFromGitHub { owner = "usebruno"; repo = "bruno"; rev = "v${version}"; - hash = "sha256-6UcByIiKBAIicH3dNF+6byuj/WsEb4Xi+iPvfjPsQkA="; + hash = "sha256-ydb80+FP2IsobvCZiIKzbErAJNakVoSoYrhddmPmYkc="; postFetch = '' ${lib.getExe npm-lockfile-fix} $out/package-lock.json ''; }; - npmDepsHash = "sha256-z8d1paC5VQ/XsXJuQ6Z7PjSwC6abN6kRmG0sfI9aCqw="; + npmDepsHash = "sha256-ODE8GLIgdUEOiniki8jzkHfU5TKHWoIIbjGJjNzMZCI="; npmFlags = [ "--legacy-peer-deps" ]; nativeBuildInputs = From 582038c3978b46a38f1b7e0735b9a13e5a78098d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gutyina=20Gerg=C5=91?= Date: Thu, 7 Nov 2024 00:57:32 +0100 Subject: [PATCH 3/5] bruno: remove `with lib;`, order meta attrs --- pkgs/by-name/br/bruno/package.nix | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkgs/by-name/br/bruno/package.nix b/pkgs/by-name/br/bruno/package.nix index 5f0e15fc5db4..4ec73a84b490 100644 --- a/pkgs/by-name/br/bruno/package.nix +++ b/pkgs/by-name/br/bruno/package.nix @@ -158,19 +158,19 @@ buildNpmPackage rec { passthru.updateScript = nix-update-script { }; - meta = with lib; { + meta = { description = "Open-source IDE For exploring and testing APIs"; homepage = "https://www.usebruno.com"; - platforms = platforms.linux ++ platforms.darwin; - license = licenses.mit; - maintainers = with maintainers; [ + license = lib.licenses.mit; + mainProgram = "bruno"; + maintainers = with lib.maintainers; [ gepbird kashw2 lucasew mattpolzin - water-sucks redyf + water-sucks ]; - mainProgram = "bruno"; + platforms = lib.platforms.linux ++ lib.platforms.darwin; }; } From cc0b65fb0495a005880312ddb901da8621b1aec4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gutyina=20Gerg=C5=91?= Date: Thu, 7 Nov 2024 01:37:53 +0100 Subject: [PATCH 4/5] bruno: add back giflib removal patch --- pkgs/by-name/br/bruno/package.nix | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkgs/by-name/br/bruno/package.nix b/pkgs/by-name/br/bruno/package.nix index 4ec73a84b490..623998e9fd61 100644 --- a/pkgs/by-name/br/bruno/package.nix +++ b/pkgs/by-name/br/bruno/package.nix @@ -78,6 +78,14 @@ buildNpmPackage rec { ELECTRON_SKIP_BINARY_DOWNLOAD = 1; + # remove giflib dependency + npmRebuildFlags = [ "--ignore-scripts" ]; + preBuild = '' + substituteInPlace node_modules/canvas/binding.gyp \ + --replace-fail "'with_gif%': ' Date: Thu, 7 Nov 2024 22:41:21 +0100 Subject: [PATCH 5/5] bruno: postBuild -> buildPhase --- pkgs/by-name/br/bruno/package.nix | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/br/bruno/package.nix b/pkgs/by-name/br/bruno/package.nix index 623998e9fd61..07e8516e308d 100644 --- a/pkgs/by-name/br/bruno/package.nix +++ b/pkgs/by-name/br/bruno/package.nix @@ -86,8 +86,9 @@ buildNpmPackage rec { npm rebuild ''; - dontNpmBuild = true; - postBuild = '' + buildPhase = '' + runHook preBuild + npm run build --workspace=packages/bruno-common npm run build --workspace=packages/bruno-graphql-docs npm run build --workspace=packages/bruno-app @@ -127,6 +128,8 @@ buildNpmPackage rec { } popd + + runHook postBuild ''; npmPackFlags = [ "--ignore-scripts" ];