From 69dfa612cc27b3495b766239dec31facb1df66b9 Mon Sep 17 00:00:00 2001
From: Fabian Affolter <mail@fabian-affolter.ch>
Date: Mon, 20 Mar 2023 01:00:29 +0100
Subject: [PATCH] python310Packages.subliminal: enable tests

- disable on unpoorted Python releases
- add changelog
- add format
- remove linting and coverage
- clean-up inputs
---
 .../python-modules/subliminal/default.nix     | 92 +++++++++++++------
 1 file changed, 66 insertions(+), 26 deletions(-)

diff --git a/pkgs/development/python-modules/subliminal/default.nix b/pkgs/development/python-modules/subliminal/default.nix
index 8c904808be25..0b6d801c8ed0 100644
--- a/pkgs/development/python-modules/subliminal/default.nix
+++ b/pkgs/development/python-modules/subliminal/default.nix
@@ -1,55 +1,95 @@
 { lib
-, fetchPypi
-, buildPythonPackage
-, guessit
+, appdirs
 , babelfish
-, enzyme
 , beautifulsoup4
-, requests
+, buildPythonPackage
+, chardet
 , click
 , dogpile-cache
-, stevedore
-, chardet
+, enzyme
+, fetchFromGitHub
+, guessit
 , pysrt
-, six
-, appdirs
-, rarfile
+, pytestCheckHook
+, pythonOlder
 , pytz
+, rarfile
+, requests
+, six
+, stevedore
 , sympy
 , vcrpy
-, pytest
-, pytest-flakes
-, pytest-cov
-, pytest-runner
 }:
 
 buildPythonPackage rec {
   pname = "subliminal";
   version = "2.1.0";
+  format = "setuptools";
 
-  src = fetchPypi {
-    inherit pname version;
-    sha256 = "12v2clnbic8320fjsvkg3xfxfa7x8inhjk61z00pzwx46g3rqhy6";
+  disabled = pythonOlder "3.7";
+
+  src = fetchFromGitHub {
+    owner = "Diaoul";
+    repo = pname;
+    rev = "refs/tags/${version}";
+    hash = "sha256-P4gVxKKCGKS3MC4F3yTAaOSv36TtdoYfrf61tBHg8VY=";
   };
 
+  postPatch = ''
+    substituteInPlace pytest.ini \
+      --replace " --pep8 --flakes" ""
+  '';
+
   propagatedBuildInputs = [
-    guessit babelfish enzyme beautifulsoup4 requests
-    click dogpile-cache stevedore chardet pysrt six
-    appdirs rarfile pytz
+    appdirs
+    babelfish
+    beautifulsoup4
+    chardet
+    click
+    dogpile-cache
+    enzyme
+    guessit
+    pysrt
+    pytz
+    rarfile
+    requests
+    six
+    stevedore
   ];
 
   nativeCheckInputs = [
-    sympy vcrpy pytest pytest-flakes
-    pytest-cov pytest-runner
+    sympy
+    vcrpy
+    pytestCheckHook
   ];
 
-  # https://github.com/Diaoul/subliminal/pull/963
-  doCheck = false;
-  pythonImportsCheck = [ "subliminal" ];
+  pythonImportsCheck = [
+    "subliminal"
+  ];
+
+  disabledTests = [
+    # Tests rewuire network access
+    "test_refine_video_metadata"
+    "test_scan"
+    "test_hash"
+    "test_provider_pool_list_subtitles"
+    "test_async_provider_pool_list_subtitles"
+    "test_list_subtitles"
+    "test_download_bad_subtitle"
+    # Not implemented
+    "test_save_subtitles"
+  ];
+
+  disabledTestPaths = [
+    # AttributeError: module 'rarfile' has no attribute 'custom_check'
+    "tests/test_legendastv.py"
+  ];
 
   meta = with lib; {
-    homepage = "https://github.com/Diaoul/subliminal";
     description = "Python library to search and download subtitles";
+    homepage = "https://github.com/Diaoul/subliminal";
+    changelog = "https://github.com/Diaoul/subliminal/blob/${version}/HISTORY.rst";
     license = licenses.mit;
+    maintainers = with maintainers; [ ];
   };
 }