From 68c06a055ac83cace7e733dc4815d08ddabd9696 Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Fri, 14 Mar 2025 22:08:23 +0100
Subject: [PATCH] python312Packages.rtslib: rename to rtslib-fb

---
 nixos/modules/services/networking/iscsi/target.nix            | 4 ++--
 pkgs/by-name/ta/targetcli/package.nix                         | 2 +-
 .../python-modules/{rtslib => rtslib-fb}/default.nix          | 4 ++--
 pkgs/top-level/python-aliases.nix                             | 1 +
 pkgs/top-level/python-packages.nix                            | 2 +-
 5 files changed, 7 insertions(+), 6 deletions(-)
 rename pkgs/development/python-modules/{rtslib => rtslib-fb}/default.nix (96%)

diff --git a/nixos/modules/services/networking/iscsi/target.nix b/nixos/modules/services/networking/iscsi/target.nix
index bfc229376895..f6c0739d0622 100644
--- a/nixos/modules/services/networking/iscsi/target.nix
+++ b/nixos/modules/services/networking/iscsi/target.nix
@@ -52,8 +52,8 @@ in
       wantedBy = [ "multi-user.target" ];
       serviceConfig = {
         Type = "oneshot";
-        ExecStart = "${pkgs.python3.pkgs.rtslib}/bin/targetctl restore";
-        ExecStop = "${pkgs.python3.pkgs.rtslib}/bin/targetctl clear";
+        ExecStart = "${lib.getExe pkgs.python3Packages.rtslib-fb} restore";
+        ExecStop = "${lib.getExe pkgs.python3Packages.rtslib-fb} clear";
         RemainAfterExit = "yes";
       };
     };
diff --git a/pkgs/by-name/ta/targetcli/package.nix b/pkgs/by-name/ta/targetcli/package.nix
index 9498717b22d6..de02714be0ac 100644
--- a/pkgs/by-name/ta/targetcli/package.nix
+++ b/pkgs/by-name/ta/targetcli/package.nix
@@ -27,7 +27,7 @@ python3.pkgs.buildPythonApplication rec {
 
   propagatedBuildInputs = with python3.pkgs; [
     configshell
-    rtslib
+    rtslib-fb
     pygobject3
   ];
 
diff --git a/pkgs/development/python-modules/rtslib/default.nix b/pkgs/development/python-modules/rtslib-fb/default.nix
similarity index 96%
rename from pkgs/development/python-modules/rtslib/default.nix
rename to pkgs/development/python-modules/rtslib-fb/default.nix
index 3ee775443e85..e9eba892e89d 100644
--- a/pkgs/development/python-modules/rtslib/default.nix
+++ b/pkgs/development/python-modules/rtslib-fb/default.nix
@@ -12,7 +12,7 @@
 }:
 
 buildPythonPackage rec {
-  pname = "rtslib";
+  pname = "rtslib-fb";
   version = "2.2.2";
   pyproject = true;
 
@@ -24,7 +24,7 @@ buildPythonPackage rec {
 
   src = fetchFromGitHub {
     owner = "open-iscsi";
-    repo = "${pname}-fb";
+    repo = "rtslib-fb";
     tag = "v${version}";
     hash = "sha256-FuXO/yGZBR+QRvB5s1tE77hjnisSfjjHSCPLvGJOYdM=";
   };
diff --git a/pkgs/top-level/python-aliases.nix b/pkgs/top-level/python-aliases.nix
index ae5fdce752b2..1bb761ce2f3d 100644
--- a/pkgs/top-level/python-aliases.nix
+++ b/pkgs/top-level/python-aliases.nix
@@ -647,6 +647,7 @@ mapAliases ({
   ronin = throw "ronin has been removed because it was unmaintained since 2018"; # added 2024-08-21
   ROPGadget = ropgadget; # added 2021-07-06
   rotate-backups = throw "rotate-backups was removed in favor of the top-level rotate-backups"; # added 2021-07-01
+  rtslib = rtslib-fb; # added 2025-03-14
   ruamel_base = ruamel-base; # added 2021-11-01
   ruamel_yaml = ruamel-yaml; # added 2021-11-01
   ruamel_yaml_clib = ruamel-yaml-clib; # added 2021-11-01
diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index 22227021a161..01cbe3947a26 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -14696,7 +14696,7 @@ self: super: with self; {
     inherit (pkgs) libspatialindex;
   };
 
-  rtslib = callPackage ../development/python-modules/rtslib { };
+  rtslib-fb = callPackage ../development/python-modules/rtslib-fb { };
 
   rtsp-to-webrtc = callPackage ../development/python-modules/rtsp-to-webrtc { };