From 6753ce53f161a9e8dcc2cf0c61c086a2f6370362 Mon Sep 17 00:00:00 2001
From: Marcin Serwin <marcin@serwin.dev>
Date: Mon, 28 Apr 2025 18:00:11 +0200
Subject: [PATCH] sdl2-compat: simplify `doCheck` logic

`stdenv.mkDerivation` already checks whether the build platform can
execute host code and disables tests if it's not supported, no need to
duplicate this logic. `doCheck` can be disabled with `overrideAttrs`, no
need for a dedicated override flag.
---
 pkgs/by-name/sd/sdl2-compat/package.nix | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pkgs/by-name/sd/sdl2-compat/package.nix b/pkgs/by-name/sd/sdl2-compat/package.nix
index 7a5972909def..e6c1fe2ccb2d 100644
--- a/pkgs/by-name/sd/sdl2-compat/package.nix
+++ b/pkgs/by-name/sd/sdl2-compat/package.nix
@@ -16,7 +16,6 @@
   testers,
   libX11,
   libGL,
-  testSupport ? true,
 }:
 
 stdenv.mkDerivation (finalAttrs: {
@@ -60,7 +59,7 @@ stdenv.mkDerivation (finalAttrs: {
   # skip timing-based tests as those are flaky
   env.SDL_TESTS_QUICK = 1;
 
-  doCheck = testSupport && stdenv.buildPlatform.canExecute stdenv.hostPlatform;
+  doCheck = true;
 
   patches = [ ./find-headers.patch ];
   setupHook = ./setup-hook.sh;