docker-language-server: cleanup

pkgs/by-name/do/docker-language-server/package.nix

@@ -4,16 +4,17 @@
   buildGoModule,
   docker,
   gotestsum,
+  versionCheckHook,
 }:
 
-buildGoModule rec {
+buildGoModule (finalAttrs: {
   pname = "docker-language-server";
   version = "0.20.1";
 
   src = fetchFromGitHub {
     owner = "docker";
     repo = "docker-language-server";
-    tag = "v${version}";
+    tag = "v${finalAttrs.version}";
     hash = "sha256-OSAySCTK2temrVxmkRnrl5YWVbmkp8DRlXFVxTzEW3Q=";
   };
 
@@ -30,23 +31,35 @@ buildGoModule rec {
     # disable some tests because of sandbox
     excludedPackages="e2e-tests|/buildkit$|/scout$"
     packages=$(go list ./... | grep -vE "$excludedPackages")
-    gotestsum -- $packages -timeout 30s -skip "TestCollectDiagnostics|TestCompletion_ImageTags|TestInlayHint"
+
-    go test ./e2e-tests/... -timeout 120s -skip "TestPublishDiagnostics|TestHover"
+    gotestsum -- $packages \
+      -timeout 30s \
+      -skip "TestCollectDiagnostics|TestCompletion_ImageTags|TestInlayHint"
+
+    go test ./e2e-tests/... \
+      -timeout 120s \
+      -skip "TestPublishDiagnostics|TestHover"
 
     runHook postCheck
   '';
 
   ldflags = [
     "-s"
-    "-w"
+    "-X 'github.com/docker/docker-language-server/internal/pkg/cli/metadata.Version=${finalAttrs.version}'"
-    "-X 'github.com/docker/docker-language-server/internal/pkg/cli/metadata.Version=${version}'"
   ];
 
-  meta = with lib; {
+  nativeInstallCheckInputs = [
-    homepage = "https://github.com/docker/docker-language-server";
+    versionCheckHook
+  ];
+  versionCheckProgramArg = "--version";
+  doInstallCheck = true;
+
+  meta = {
     description = "Language server for providing language features for file types in the Docker ecosystem (Dockerfiles, Compose files, and Bake files)";
+    homepage = "https://github.com/docker/docker-language-server";
+    changelog = "https://github.com/docker/docker-language-server/blob/${finalAttrs.src.tag}/CHANGELOG.md";
     mainProgram = "docker-language-server";
-    license = licenses.asl20;
+    license = lib.licenses.asl20;
-    maintainers = with maintainers; [ baongoc124 ];
+    maintainers = with lib.maintainers; [ baongoc124 ];
   };
-}
+})