From 643dfd4db3bcd8d84d045fad77f412bff2c7dcfc Mon Sep 17 00:00:00 2001
From: Reno Dakota <paparodeo@proton.me>
Date: Thu, 19 Dec 2024 21:03:39 -0800
Subject: [PATCH] arrow-cpp: fix build with clang-19

remove unsupported char_traits in buffer_test.cc.

fixed upstream
https://github.com/apache/arrow/pull/44493/files#diff-4b62e1208918e95c9fc3cf45848dd295dda6961cfec92cb1be98d83bf890fbf5
---
 pkgs/by-name/ar/arrow-cpp/package.nix | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/pkgs/by-name/ar/arrow-cpp/package.nix b/pkgs/by-name/ar/arrow-cpp/package.nix
index e972bf1d3080..f8ba34710dcb 100644
--- a/pkgs/by-name/ar/arrow-cpp/package.nix
+++ b/pkgs/by-name/ar/arrow-cpp/package.nix
@@ -3,6 +3,7 @@
   lib,
   fetchurl,
   fetchFromGitHub,
+  fetchpatch,
   fixDarwinDylibNames,
   autoconf,
   aws-sdk-cpp,
@@ -93,6 +94,17 @@ stdenv.mkDerivation (finalAttrs: {
 
   sourceRoot = "${finalAttrs.src.name}/cpp";
 
+  patches = [
+    # fixes build with libcxx-19 (llvm-19) remove on update
+    (fetchpatch {
+      name = "libcxx-19-fixes.patch";
+      url = "https://github.com/apache/arrow/commit/29e8ea011045ba4318a552567a26b2bb0a7d3f05.patch";
+      relative = "cpp";
+      includes = [ "src/arrow/buffer_test.cc" ];
+      hash = "sha256-ZHkznOilypi1J22d56PhLlw/hbz8RqwsOGDMqI1NsMs=";
+    })
+  ];
+
   # versions are all taken from
   # https://github.com/apache/arrow/blob/apache-arrow-${version}/cpp/thirdparty/versions.txt